Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge bitcoin/bitcoin#31489: fuzz: Fix test_runner error reporting
fa0e30b fuzz: Fix test_runner error reporting (MarcoFalke) Pull request description: The error reporting is confusing, because right now it prints: https://cirrus-ci.com/task/4846031060336640?logs=ci#L4931 ``` ... Traceback (most recent call last): File "/ci_container_base/ci/scratch/build-x86_64-pc-linux-gnu/test/fuzz/test_runner.py", line 411, in <module> main() File "/ci_container_base/ci/scratch/build-x86_64-pc-linux-gnu/test/fuzz/test_runner.py", line 199, in main run_once( File "/ci_container_base/ci/scratch/build-x86_64-pc-linux-gnu/test/fuzz/test_runner.py", line 376, in run_once assert len(done_stat) == 1 ^^^^^^^^^^^^^^^^^^^ AssertionError ``` This is harmless, but confusing. Fix it by collecting statistics only when the program has not aborted. (Can be reviewed with `--color-moved=dimmed-zebra`) Also, reword the error message to align it with error messages in other test_runners in this repo. ACKs for top commit: dergoegge: utACK fa0e30b brunoerg: code review ACK fa0e30b marcofleon: Tested ACK fa0e30b. Prints out the error for the target that crashed. Much clearer than the current error message. Tree-SHA512: 5e8d3fc0e4837b3264ff0c3cb322fe7fe2ec7af48d35e2a14f82080d03ace793963c3314611b0a170a38e200497d7ba703d9c35c9a7ed3272d93e43f0f0e4c2b
- Loading branch information