Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(biome_js_analyzer): useTrimStartEnd #3123

Open
wants to merge 31 commits into
base: main
Choose a base branch
from

Conversation

chansuke
Copy link
Member

@chansuke chansuke commented Jun 8, 2024

Summary

Part of #2817

Test Plan

just test-lintrule useTrimStartEnd

@github-actions github-actions bot added A-CLI Area: CLI A-Project Area: project A-Linter Area: linter L-JavaScript Language: JavaScript and super languages A-Diagnostic Area: diagnostocis labels Jun 8, 2024
Copy link

codspeed-hq bot commented Jun 8, 2024

CodSpeed Performance Report

Merging #3123 will degrade performances by 7.69%

Comparing chansuke:feat/use-trim-start-end (fad4c97) with main (a77c00b)

Summary

❌ 1 regressions
✅ 107 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main chansuke:feat/use-trim-start-end Change
db_2930068967297060348.json[uncached] 14.8 ms 16 ms -7.69%

@chansuke chansuke marked this pull request as ready for review June 8, 2024 03:09
@chansuke chansuke requested a review from minht11 June 8, 2024 13:10
@chansuke chansuke force-pushed the feat/use-trim-start-end branch 2 times, most recently from 71b7992 to 59739a4 Compare June 9, 2024 15:49
@chansuke chansuke requested a review from togami2864 June 9, 2024 16:26
@chansuke chansuke force-pushed the feat/use-trim-start-end branch 4 times, most recently from 75b1aaf to d0b13d1 Compare June 12, 2024 16:52
@chansuke chansuke requested a review from Sec-ant June 13, 2024 03:47
Copy link
Member

@Sec-ant Sec-ant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's rerun the codegen task to pass the check.

@chansuke chansuke requested a review from Sec-ant June 13, 2024 07:01
Copy link
Member

@Sec-ant Sec-ant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments on the test cases. Also, could you please add a changelog entry for this rule and noSubstr, the one you worked on earlier?

@github-actions github-actions bot added the A-Changelog Area: changelog label Jun 13, 2024
@chansuke chansuke requested a review from Sec-ant June 13, 2024 17:17
@chansuke chansuke requested a review from Sec-ant June 14, 2024 04:09
@chansuke chansuke requested a review from Sec-ant June 15, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-CLI Area: CLI A-Diagnostic Area: diagnostocis A-Linter Area: linter A-Project Area: project L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants