Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

localization: Move from orangecanvas.utils to orangecanvas #320

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

janezd
Copy link
Contributor

@janezd janezd commented Dec 13, 2024

Presumably fixes biolab/orange3#6952: localization used to be inside orangecanvas.utils, and orange.canvas.utils.__init__ required Qt.

This PR moves localization to the root to avoid depending on Qt. Old imports are deprecated, but work.

@janezd janezd changed the title localization: Move from to localization: Move from orangecanvas.utils to orangecanvas Dec 13, 2024
@janezd janezd force-pushed the move-localization branch 2 times, most recently from c853f41 to f3b2a7c Compare December 13, 2024 10:58
@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 71.18644% with 34 lines in your changes missing coverage. Please review.

Project coverage is 76.57%. Comparing base (86724ab) to head (f1f9e82).

Files with missing lines Patch % Lines
orangecanvas/localization/__init__.py 56.57% 33 Missing ⚠️
orangecanvas/localization/si.py 97.14% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #320      +/-   ##
==========================================
- Coverage   76.57%   76.57%   -0.01%     
==========================================
  Files         100      102       +2     
  Lines       21240    21255      +15     
==========================================
+ Hits        16265    16275      +10     
- Misses       4975     4980       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@janezd janezd marked this pull request as ready for review December 13, 2024 12:27
@markotoplak markotoplak merged commit ed4d4f9 into biolab:master Dec 16, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Orange wheel requires Qt
3 participants