meraculous: add linux-aarch64 build #50566
Open
+23
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The Linux ARM64 build depends on missing |
|
The Linux ARM64 build depends on missing |
martin-g
force-pushed
the
aarch64-meraculous
branch
from
3810832
to
b6f1884
Compare
📝 Walkthrough📝 WalkthroughWalkthroughThe pull request introduces modifications to two files: Possibly related PRs
Suggested labels
Suggested reviewers
Warning Rate limit exceeded@martin-g has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 19 minutes and 19 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
recipes/meraculous/meta.yaml (1)
Line range hint
22-35: Add missing perl-dbi dependencyBased on the PR comments, this package requires
perl-dbi, but it's not listed in the requirements section. Please add it to bothhostandrunrequirements once the conda-forge/perl-dbi-feedstock PR is merged.host: - libgd >=2.0 - boost-cpp - perl - perl-log-log4perl >=1.31 - gnuplot >=3.7 + - perl-dbi run: - libgd >=2.0 - boost-cpp - perl - perl-log-log4perl >=1.31 - gnuplot >=3.7 + - perl-dbi
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (2)
recipes/meraculous/build.sh(1 hunks)recipes/meraculous/meta.yaml(2 hunks)
🔇 Additional comments (4)
recipes/meraculous/build.sh (2)
3-4: LGTM! Enhanced error handling and debugging
Adding set -xe is a good practice that will help catch build failures early and provide better debugging information, especially important for the new ARM64 platform support.
11-11: LGTM! Optimized build performance
The addition of parallel compilation with -j ${CPU_COUNT} is a good optimization that follows Conda build best practices.
recipes/meraculous/meta.yaml (2)
16-18: LGTM! Good addition of run_exports.
The addition of run_exports with appropriate pinning will help maintain ABI compatibility for downstream packages.
56-57: Verify all dependencies for linux-aarch64
While adding linux-aarch64 support, please ensure all dependencies are available for this architecture. Currently, there's a known issue with the perl-dbi package.
martin-g
force-pushed
the
aarch64-meraculous
branch
from
b6f1884
to
fa89ec5
Compare
Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
martin-g
force-pushed
the
aarch64-meraculous
branch
from
fa89ec5
to
a02cf69
Compare
Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
|
@BiocondaBot please fetch artifacts |
|
Package(s) built are ready for inspection:
Docker image(s) built:
|
LGTM! |
|
@BiocondaBot please add label |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your pull request here
Please read the guidelines for Bioconda recipes before opening a pull request (PR).
General instructions
@BiocondaBot please add labelcommand.@bioconda/corein a comment.Instructions for avoiding API, ABI, and CLI breakage issues
Conda is able to record and lock (a.k.a. pin) dependency versions used at build time of other recipes.
This way, one can avoid that expectations of a downstream recipe with regards to API, ABI, or CLI are violated by later changes in the recipe.
If not already present in the meta.yaml, make sure to specify
run_exports(see here for the rationale and comprehensive explanation).Add a
run_exportssection like this:with
...being one of:{{ pin_subpackage("myrecipe", max_pin="x") }}{{ pin_subpackage("myrecipe", max_pin="x.x") }}{{ pin_subpackage("myrecipe", max_pin="x.x") }}(in such a case, please add a note that shortly mentions your evidence for that){{ pin_subpackage("myrecipe", max_pin="x.x.x") }}(in such a case, please add a note that shortly mentions your evidence for that){{ pin_subpackage("myrecipe", max_pin=None) }}while replacing
"myrecipe"with eithernameif aname|lowervariable is defined in your recipe or with the lowercase name of the package in quotes.Bot commands for PR management
Please use the following BiocondaBot commands:
Everyone has access to the following BiocondaBot commands, which can be given in a comment:
@BiocondaBot please update@BiocondaBot please add labelplease review & mergelabel.@BiocondaBot please fetch artifactsYou can use this to test packages locally.
Note that the
@BiocondaBot please mergecommand is now depreciated. Please just squash and merge instead.Also, the bot watches for comments from non-members that include
@bioconda/<team>and will automatically re-post them to notify the addressed<team>.