Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update primerforge to 1.2.5 #48898

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Update primerforge to 1.2.5 #48898

wants to merge 6 commits into from

Conversation

BiocondaBot
Copy link
Collaborator

Update primerforge: 1.1.11.2.5

install with bioconda Conda

Info Link or Description
Recipe recipes/primerforge (click to view/edit other files)
Summary primerForge: software to identify primers that can be used to distinguish genomes
Home https://github.com/dr-joe-wirth/primerForge
Releases https://github.com/dr-joe-wirth/primerForge/tags
Recipe Maintainer(s) @dr-joe-wirth
Author @dr-joe-wirth

This pull request was automatically generated (see docs).

@BiocondaBot BiocondaBot added autobump Automatic Version Update new version labels Jul 2, 2024
recipes/primerforge/meta.yaml Outdated Show resolved Hide resolved
recipes/primerforge/meta.yaml Outdated Show resolved Hide resolved
@dr-joe-wirth
Copy link
Contributor

not sure how to fix this. in my environment.yml file, it did not work when I specified it as @martin-g did. It only worked when I allowed pip to install the package.

i'd gladly change it, but i'm unsure how to track down and resolve the conflict.

@martin-g
Copy link
Contributor

martin-g commented Jul 3, 2024

Which version has been installed by pip ? Maybe we can try with exact version instead of a range ?!

@dr-joe-wirth
Copy link
Contributor

dr-joe-wirth commented Jul 3, 2024

Which version has been installed by pip ? Maybe we can try with exact version instead of a range ?!

version 2.1.1. So i had thought that specfiying khmer >=2.1 would be sufficient.

https://pypi.org/project/khmer/

just checked the bioconda page for khmer...it appears that 2.1.1 is not a version there.

looks like maybe the problem is the version of python it is dependent on:

depends python: >=3.6,<3.7.0a0

primerforge would need at least v3.9+ since it uses typehinting which wasn't formally supported until 3.9. I would expect to get a lot of errors saying like "cannot subset type tuple" because a function's signature line had something like def f(n:int) -> tuple[str,int]:. I am not entirely sure what version of python allows this, but i know with certainty that 3.7 would complain.

@dr-joe-wirth
Copy link
Contributor

would including a line like pip install khmer in a build.sh file be compliant with bioconda syntax? or is this still a bad practice?

@rpetit3
Copy link
Member

rpetit3 commented Jul 4, 2024

I think we have a few options

  1. Try building khmer 2.1.1 with latest python pinnings
  2. try rebuilding khmer 2.1 with latest python pinnings
  3. (do not recommend) pingeon-hole primerforge to only work with python 3.6 (which might not even be supported by primerforge)

@rpetit3
Copy link
Member

rpetit3 commented Jul 4, 2024

would including a line like pip install khmer in a build.sh file be compliant with bioconda syntax? or is this still a bad practice?

You are correct, this wouldn't be allowed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autobump Automatic Version Update new version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants