Various updates #45
Various updates #45
Conversation
note that this local channel setup may not be required anymore; the test linux-aarch64 builds completed successfully even without this. But adding it in for completion's sake.
Only appears to be used in the now-deprecated bioconda-actions repo.
| **`common.sh`:** contains environment variables that control versions. | ||
|
|
||
| **`install-and-set-up-conda.sh`:** | ||
| - downloads and installs conda using the Mambaforge distribution |
There was a problem hiding this comment.
We should not use mambaforge anymore. Conda-forge discourages it and advertises miniforge.
With the release of Miniforge3-23.3.1-0, that incorporated the changes in conda-forge/miniforge#277, the packages and configuration of Mambaforge and Miniforge3 are now identical. The only difference between the two is the name of the installer and, subsequently, the default installation directory.
Given its wide usage, there are no plans to deprecate Mambaforge. If at some point we decide to deprecate Mambaforge, it will be appropriately announced and communicated with sufficient time in advance.
As of September 2023, the new usage of Mambaforge is thus discouraged. Bug reports specific to Mambaforge will be closed as won't fix.
There was a problem hiding this comment.
Was not aware of this, thanks for pointing it out.
This PR was mostly about documentation; do you think it's worth changing mambaforge -> miniforge in this PR? Theoretically it should not change anything in the build process since we're already on 23.3.1, so this is more a question of "do you think it will actually not change anything".
There was a problem hiding this comment.
A different PR is ok. But we should get rid of it at some point.
| 1. Download the files, typically via: | ||
|
|
||
| ```bash | ||
| wget https://raw.githubusercontent.com/bioconda/bioconda-common/master/{common,install-and-set-up-conda,configure-conda}.sh |
There was a problem hiding this comment.
Maybe 3 separate commands? I guess the intention here is to copy-and-paste?
There was a problem hiding this comment.
I was documenting what we currently have. Could go either way, but I guess it's slightly easier to copy-paste this single line.
MINICONDA_VER. It only appears to be used in the now-deprecated bioconda-actions repo, and we're using mambaforge anyway.linux-aarch64to the local channels. This is just to be complete -- I'm not sure this local channel setup is actually needed any more, because the pilot ARM builds worked OK. However, this may end up being important when there are many dependencies being built in which case the local channel should have priority.configure-conda.shto the test in this repo just to be complete.