Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in parallel pipelines caused by false reporting of fids #568

Draft
wants to merge 1 commit into
base: future
Choose a base branch
from

Conversation

tammam1998
Copy link
Collaborator

Fids with no input or output nodes were reported as output fids and input fids causing some conflicts in parallel pipelines (specifically in the distributed execution mode since we replace hdfs cat input fids with an input per block).

Note: this is not a complete solution. replacing HDFSCat with per block cat could cause some conflicts to go undetected. Example: (x | x | x | hdfs dfs -put -f - /1.txt; hdfs dfs -cat) where /1.txt existed before.

@angelhof
Copy link
Member

Hmm, so the issue was there there existed fids with no input or output node in the graph, and so they were returned as input/output fids of the graph right?

I think the solution should include figuring out who leaks these None to None fids.

BTW, I am not sure I understand the missed conflicts that you are mentioning. We could discuss this out of the critical path however.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants