Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rust-version 1.70 #813

Merged
merged 1 commit into from
Oct 20, 2024
Merged

Add rust-version 1.70 #813

merged 1 commit into from
Oct 20, 2024

Conversation

jayvdb
Copy link
Contributor

@jayvdb jayvdb commented Sep 8, 2024

Current reason for msrv is clap, c.f. #803

@jayvdb jayvdb mentioned this pull request Sep 8, 2024
Merged
waywardmonkeys
waywardmonkeys approved these changes Sep 8, 2024
View reviewed changes
Copy link
Contributor

@waywardmonkeys waywardmonkeys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine. Could probably apply the same to some of the other crates or in the future, switch to workspace inheritance to configure it once for all crates within the workspace.

@lemmih lemmih merged commit d2e705b into bheisler:master Oct 20, 2024
@jayvdb jayvdb deleted the add-msrv branch October 20, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waywardmonkeys waywardmonkeys waywardmonkeys approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jayvdb @waywardmonkeys @lemmih