Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make height width non required #38

Merged
merged 1 commit into from
May 21, 2024
Merged

Conversation

bharat-1809
Copy link
Owner

Overview

Fixes: #10

  • Make the height and width param un-required.
  • Update tests
  • Update example to handle the added feature

Copy link

codecov bot commented May 21, 2024

Codecov Report

Attention: Patch coverage is 93.61702% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 83.33%. Comparing base (daa6c30) to head (bce5916).

Current head bce5916 differs from pull request most recent head 31806b3

Please upload reports for the commit 31806b3 to get more accurate results.

Files Patch % Lines
lib/src/glass_container.dart 92.68% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #38      +/-   ##
==========================================
+ Coverage   81.56%   83.33%   +1.77%     
==========================================
  Files           2        3       +1     
  Lines         141      156      +15     
==========================================
+ Hits          115      130      +15     
  Misses         26       26              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bharat-1809 bharat-1809 merged commit b690075 into main May 21, 2024
1 of 3 checks passed
@bharat-1809 bharat-1809 deleted the bharat/un-req-size branch May 21, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: remove the requirement of width / height
1 participant