Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spaces to match formatting by taplo in guide and notes generators #1452

Merged
merged 1 commit into from
Jun 22, 2024

Conversation

rparrett
Copy link
Contributor

This will make generated toml by these tools more closely match the formatting that is produced by taplo (as recommended in CONTRIBUTING.md). This should result in less of a mess when someone's editor auto-formats them.

There are some places where this still won't match because there are many entries in the array and they won't fit on one line. We should probably be using the toml crate to generate this instead of building it manually.

[[guides]]
title = "Decouple `BackgroundColor` from `UiImage`"
url = "https://github.com/bevyengine/bevy/pull/11165"
- areas = ["Rendering","UI"]
+ areas = ["Rendering", "UI"]
file_name = "11165_Decouple_BackgroundColor_from_UiImage.md"
[[release_notes]]
title = "Upstreaming bevy_color."
- authors = ["@viridia","@mockersf"]
+ authors = ["@viridia", "@mockersf"]
url = "https://github.com/bevyengine/bevy/pull/12013"
file_name = "12013_Upstreaming_bevy_color.md"

@rparrett rparrett added C-Bug A problem with the code that runs the site A-Migration Guides A-Release-Notes labels Jun 21, 2024
@rparrett rparrett changed the title Add spaces to match formatting by taplo in migration guide / release notes generators Add spaces to match formatting by taplo in guide and notes generators Jun 21, 2024
@alice-i-cecile
Copy link
Member

Progress towards #1200.

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jun 22, 2024
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review Ready for a maintainer to consider for merging label Jun 22, 2024
Merged via the queue into bevyengine:main with commit 8fb14d4 Jun 22, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Migration Guides A-Release-Notes C-Bug A problem with the code that runs the site S-Ready-For-Final-Review Ready for a maintainer to consider for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants