Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always install Rust and use Leafwing-Studios/cargo-cache #1405

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

BD103
Copy link
Member

@BD103 BD103 commented Jun 14, 2024

This PR has two parts:

  1. Some jobs don't actually install Rust before using it. This doesn't error because Github's hosted runners come pre-installed with Rust, though it is frequently outdated.
  2. Use Leafwing-Studios/cargo-cache for all jobs that use Rust. This action is wonderful: I've been using it successfully for a month or so now. (Also it's by our friends at Leafwing, so it can be trusted!) This should speed up many jobs without the usual tradeoffs of caching.

@BD103 BD103 requested a review from mockersf June 14, 2024 16:17
@BD103 BD103 added C-Bug A problem with the code that runs the site C-Enhancement New feature or request A-Build-System S-Needs-Review X-Contentious There are nontrivial implications that should be thought through labels Jun 14, 2024
@BD103
Copy link
Member Author

BD103 commented Jun 14, 2024

I'm marking this as contentious because it is pulling in an outside dependency, but I feel like it's from a trusted source. If this gets major pushback, we can fork Leafwing-Studios/cargo-cache under the Bevy organization and frequently update it.

@BD103
Copy link
Member Author

BD103 commented Jun 14, 2024

I'm rebasing this on top of #1403 so CI passes. Consider this blocked until that PR is merged.

@rparrett
Copy link
Contributor

Just linking in discussion from the twin PR for the bevy repo. bevyengine/bevy#13040

@alice-i-cecile
Copy link
Member

Yeah no objection to handing off ownership to the Bevy org if this appeals to y'all :)

@BD103 BD103 removed the S-Blocked label Jun 14, 2024
Github hosted runners come preinstalled with Rust[^0], though it is often outdated. We should prefer to manually install it, since it gives us control over the version being used.

[^0]: https://github.com/actions/runner-images/blob/main/images/ubuntu/Ubuntu2204-Readme.md#rust-tools
@janhohenheim janhohenheim added S-Ready-For-Final-Review Ready for a maintainer to consider for merging and removed S-Needs-Review labels Jul 3, 2024
@BD103
Copy link
Member Author

BD103 commented Jul 16, 2024

@mockersf what are your thoughts on merging this? It would provide a good testing ground for introducing this action to the main Bevy repository, and Alice even offered transferring the repository.

@janhohenheim
Copy link
Member

Note that cargo-cache is about to release v2: Leafwing-Studios/cargo-cache#17

.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
Co-authored-by: Jan Hohenheim <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Build-System C-Bug A problem with the code that runs the site C-Enhancement New feature or request S-Ready-For-Final-Review Ready for a maintainer to consider for merging X-Contentious There are nontrivial implications that should be thought through
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants