Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_release_notes.toml formatting does not have standard formatting #1200

Open
alice-i-cecile opened this issue May 26, 2024 · 3 comments
Open
Labels
A-Release-Notes C-Automation Tools to make repetitive tasks easier C-Usability E-Good-First-Issue Good for newcomers

Comments

@alice-i-cecile
Copy link
Member

This creates nasty diffs during format-on-save.

image

Missing spaces.

image

Line breaks.

@IceSentry
Copy link
Contributor

I think the easiest thing to do would be to make sure to save the file with a formatter before opening the first PR. We can add the spaces for the list, but the newlines on longer list I don't really know what the heuristic would be for that.

@IceSentry
Copy link
Contributor

oh, but that file is regenerated every time, right....

@rparrett
Copy link
Contributor

Does the toml crate's pretty serialization match the expected format?

I'll try to remember to look into that at some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Release-Notes C-Automation Tools to make repetitive tasks easier C-Usability E-Good-First-Issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants