Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix invocation and permissions for notifications #4176

Merged
merged 2 commits into from
Sep 21, 2024
Merged

Fix invocation and permissions for notifications #4176

merged 2 commits into from
Sep 21, 2024

Conversation

haslinghuis
Copy link
Member

@haslinghuis haslinghuis added this to the 11.0 milestone Sep 20, 2024
@haslinghuis haslinghuis self-assigned this Sep 20, 2024
@netlify Netlify
Copy link

netlify bot commented Sep 20, 2024 •
edited
Loading

✅ Deploy Preview for origin-betaflight-app ready!

Name Link
🔨 Latest commit ec4fa45
🔍 Latest deploy log https://app.netlify.com/sites/origin-betaflight-app/deploys/66edccd137ddfc0008ba0799
😎 Deploy Preview https://deploy-preview-4176.dev.app.betaflight.com
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@haslinghuis haslinghuis marked this pull request as draft September 20, 2024 17:34
@nerdCopter
Copy link
Member

Win11 + MS Edge on VM (VMWare Workstation on Linux)
image
only had to click connect
image

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 20, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@haslinghuis haslinghuis marked this pull request as ready for review September 20, 2024 19:29
@haslinghuis haslinghuis changed the title Fix usage of getConfig Fix invocation and permissions for notifications Sep 20, 2024
@VitroidFPV VitroidFPV merged commit 4e553d9 into betaflight:master Sep 21, 2024
8 checks passed
@haslinghuis haslinghuis deleted the fix-permission branch September 21, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VitroidFPV VitroidFPV VitroidFPV approved these changes

@nerdCopter nerdCopter nerdCopter approved these changes

Assignees

@haslinghuis haslinghuis

Labels
RN: BUGFIX
Projects
Finalizing Firmware 4.6 Release
Status: Done
Milestone
11.0
Development

Successfully merging this pull request may close these issues.

after firmware flashing bootloader mode stands
3 participants
@haslinghuis @nerdCopter @VitroidFPV