Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AWS config share #23

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

AWS config share #23

wants to merge 1 commit into from

Conversation

neckhair
Copy link
Member

No description provided.

@neckhair neckhair self-assigned this Jun 28, 2024
cldmstr
cldmstr reviewed Jun 28, 2024
View reviewed changes
Copy link
Member

@cldmstr cldmstr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice, left one nit, but the rest is a really nice and informative read. Learned something already, today. :-) Left this as a comment, but could be released IMO, review is a nit.

content/posts/aws-config-sharing/index.md

![AWS Landing Zone](org-structure.drawio.png)

The management account contains your definition of the organizational structure. The Network account
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: You capitalize "Network account" but not "management account" IMO it would be good to be consistent. No preference for either way. The capitalization is more British, the other more International.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cldmstr cldmstr cldmstr left review comments

Assignees

@neckhair neckhair

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@neckhair @cldmstr