Add an explicit width to SVGs not rendering in Firefox #78
+11
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qasimwarraich
changed the title
qasimwarraich
force-pushed
the
fix/some-svgs-dont-register-in-firefox
branch
from
1ffaebc
to
4c0b36d
Compare
qasimwarraich
changed the title
qasimwarraich
force-pushed
the
fix/some-svgs-dont-register-in-firefox
branch
from
4c0b36d
to
c614a3a
Compare
|
Awesome. Thanks, @qasimwarraich! Please quickly run SVGO (e.g., by running |
cloudlena
force-pushed
the
main
branch
2 times, most recently
from
f199525
to
bee3744
Compare
qasimwarraich
force-pushed
the
fix/some-svgs-dont-register-in-firefox
branch
from
144cd93
to
d522c7f
Compare
Done :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out Firefox expects SVGs to have a width, I believe height only is also sufficient. I just added a height similar to the one in the Azure logo. Scaling is not affected, but that is a bit inconsistent for some of the images anyway, I will investigate that in a separate PR.