Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4290 - Improve collection page edit #4333

Open
wants to merge 7 commits into
base: development
Choose a base branch
from
Open

4290 - Improve collection page edit #4333

wants to merge 7 commits into from

Conversation

WillNigel23
Copy link
Collaborator

No description provided.

@WillNigel23 WillNigel23 linked an issue Sep 12, 2024 that may be closed by this pull request
page settings redesign #4290
Open
@saracarl
Copy link
Collaborator

looks fine, other than an HTR nav to nowhere! (and failing tests...)

@WillNigel23
Copy link
Collaborator Author

Still WIP. Please do not merge to dev yet.

@benwbrum
Copy link
Owner

I've merged this into 3890. Should I delete the branch and PR or are you still working on it, @WillNigel23 ?

WillNigel23
WillNigel23 commented Sep 18, 2024
View reviewed changes
app/models/page.rb
'image/gif',
'image/bmp',
'image/tiff'
].freeze
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review if I have covered all accepted files for page images here

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation says: Acceptable file formats: PDF, PNG, GIF, JPG, TIF

We're not supporting PDF for an individual page upload, but we should support the others. Are we transforming them? I think we do transform some if they are uploaded in a zip file for an initial upload.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently our filepicker component only accepts image files

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In any case, #3890 can add more supported files here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benwbrum benwbrum Awaiting requested review from benwbrum

@saracarl saracarl Awaiting requested review from saracarl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

page settings redesign
3 participants
@WillNigel23 @saracarl @benwbrum