-
-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added decoration builder #108
Added decoration builder #108
Conversation
Thank @Sourav-Sonkar for your contriubtion |
@bensonarafat Should i remove the Deprecated tag or remove the decoration parameter to fix the lint?? |
@Sourav-Sonkar |
@bensonarafat we can keep both ... but i think it would made more sense to keep DecorationBuilder only...as both will be returning decoration only |
0684860
to
865793b
Compare
@bensonarafat removed decoration parameter |
Great @Sourav-Sonkar |
@bensonarafat add documentation please check |
Great @Sourav-Sonkar |
#107
Decoration need to have access target property,as if we need to pass a custom shape , then we need get access to the target property.
Suggestion to have a call back method which provides target in the supertooltip