Merge pull request #3196 from washeck/3195-http-version-error

Fix InvalidHTTPVersion exception str method
benoitc · Jul 4, 2024 · 79b9a52 · 79b9a52
2 parents 405c3ca + 97f87ec
commit 79b9a52
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/gunicorn/http/errors.py b/gunicorn/http/errors.py
@@ -53,7 +53,7 @@ def __init__(self, version):
         self.version = version
 
     def __str__(self):
-        return "Invalid HTTP Version: %r" % self.version
+        return "Invalid HTTP Version: %r" % (self.version,)
 
 
 class InvalidHeader(ParseException):

diff --git a/tests/test_http.py b/tests/test_http.py
@@ -9,7 +9,7 @@
 from gunicorn.http.body import Body, LengthReader, EOFReader
 from gunicorn.http.wsgi import Response
 from gunicorn.http.unreader import Unreader, IterUnreader, SocketUnreader
-from gunicorn.http.errors import InvalidHeader, InvalidHeaderName
+from gunicorn.http.errors import InvalidHeader, InvalidHeaderName, InvalidHTTPVersion
 from gunicorn.http.message import TOKEN_RE
 
 
@@ -238,3 +238,8 @@ def test_eof_reader_read_invalid_size():
         reader.read([100])
     with pytest.raises(ValueError):
         reader.read(-100)
+
+
+def test_invalid_http_version_error():
+    assert str(InvalidHTTPVersion('foo')) == "Invalid HTTP Version: 'foo'"
+    assert str(InvalidHTTPVersion((2, 1))) == 'Invalid HTTP Version: (2, 1)'