Fix square#1729. Properly handle type resolving for type parameters.

bennyhuo · Sep 14, 2023 · c9e0aa2 · c9e0aa2
1 parent 24cf12c
commit c9e0aa2
Show file tree

Hide file tree

Showing 4 changed files with 54 additions and 2 deletions.
diff --git a/moshi-kotlin-codegen/src/main/java/com/squareup/moshi/kotlin/codegen/apt/metadata.kt b/moshi-kotlin-codegen/src/main/java/com/squareup/moshi/kotlin/codegen/apt/metadata.kt
@@ -332,7 +332,13 @@ private fun resolveTypeArgs(
 ): TypeName {
   val unwrappedType = propertyType.unwrapTypeAlias()
 
-  if (unwrappedType !is TypeVariableName) {
+  if (unwrappedType is ParameterizedTypeName) {
+    return unwrappedType.copy(
+      typeArguments = unwrappedType.typeArguments.map {
+        resolveTypeArgs(targetClass, it, resolvedTypes, allowedTypeVars, entryStartIndex)
+      },
+    )
+  } else if (unwrappedType !is TypeVariableName) {
     return unwrappedType
   } else if (entryStartIndex == -1) {
     return unwrappedType

diff --git a/moshi-kotlin-codegen/src/main/java/com/squareup/moshi/kotlin/codegen/ksp/TargetTypes.kt b/moshi-kotlin-codegen/src/main/java/com/squareup/moshi/kotlin/codegen/ksp/TargetTypes.kt
@@ -228,7 +228,9 @@ private fun declaredProperties(
   val result = mutableMapOf<String, TargetProperty>()
   for (property in classDecl.getDeclaredProperties()) {
     val initialType = property.type.resolve()
-    val resolvedType = if (initialType.declaration is KSTypeParameter) {
+    val resolvedType = if (initialType.declaration is KSTypeParameter ||
+      initialType.arguments.any { it.type?.resolve()?.declaration is KSTypeParameter }
+    ) {
       property.asMemberOf(originalType.asType())
     } else {
       initialType

diff --git a/...egen/src/test/java/com/squareup/moshi/kotlin/codegen/apt/JsonClassCodegenProcessorTest.kt b/...egen/src/test/java/com/squareup/moshi/kotlin/codegen/apt/JsonClassCodegenProcessorTest.kt
@@ -510,6 +510,28 @@ class JsonClassCodegenProcessorTest {
     assertThat(result.messages).contains("JsonQualifier @UpperCase must have RUNTIME retention")
   }
 
+  @Test
+  fun genericSuperClassPropertyTypeSubstitution() {
+    val result = compile(
+      kotlin(
+        "source.kt",
+        """
+          package test
+          import com.squareup.moshi.JsonClass
+
+          open class GenericSuperClass<T> {
+            var t: T? = null
+            var list: List<T>? = null
+          }
+
+          @JsonClass(generateAdapter = true)
+          class SubClassOfGeneric : GenericSuperClass<String>()
+          """,
+      ),
+    )
+    assertThat(result.exitCode).isEqualTo(KotlinCompilation.ExitCode.OK)
+  }
+
   @Test
   fun `TypeAliases with the same backing type should share the same adapter`() {
     val result = compile(

diff --git a/...degen/src/test/java/com/squareup/moshi/kotlin/codegen/ksp/JsonClassSymbolProcessorTest.kt b/...degen/src/test/java/com/squareup/moshi/kotlin/codegen/ksp/JsonClassSymbolProcessorTest.kt
@@ -557,6 +557,28 @@ class JsonClassSymbolProcessorTest {
     assertThat(result.messages).contains("Error preparing ElementEnvelope")
   }
 
+  @Test
+  fun genericSuperClassPropertyTypeSubstitution() {
+    val result = compile(
+      kotlin(
+        "source.kt",
+        """
+          package test
+          import com.squareup.moshi.JsonClass
+
+          open class GenericSuperClass<T> {
+            var t: T? = null
+            var list: List<T>? = null
+          }
+
+          @JsonClass(generateAdapter = true)
+          class SubClassOfGeneric : GenericSuperClass<String>()
+          """,
+      ),
+    )
+    assertThat(result.exitCode).isEqualTo(KotlinCompilation.ExitCode.OK)
+  }
+
   @Test
   fun `TypeAliases with the same backing type should share the same adapter`() {
     val result = compile(