Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add color picker widget #1012

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add color picker widget #1012

wants to merge 3 commits into from

Conversation

ellieeet123
Copy link
Contributor

Adds a color picker widget above search results when the keyword "color" or "colour" is in the query. Also slightly refactors the widget inserting code in the backend.

Note - During the writing of this I was interrupted by some real-life drama and had to step away from it for a few months and kind of forgot what I was doing here, so the code's quality isn't amazing. If you want to (or want me to) feel free to improve it or ask me to. But as far as I know it works for now.

@benbusby
Copy link
Owner

I'm a bit on the fence about this. I do like the idea of having a color picker embedded in Whoogle, but this seems like a fair amount of additional code that I'd need to maintain moving forward, and I'm trying to keep Whoogle as minimal as possible. Plus I think a lot of people who use color pickers (myself included) are fine with either using a browser extension or something like Firefox's built in eyedropper. It'd be nice if there was a way to load extensions from someone else's repo so that it could stay separate from Whoogle, but idk how well/if that would work.

@cazwacki cazwacki mentioned this pull request Jul 10, 2023
16 tasks
@ellieeet123
Copy link
Contributor Author

That's definitely fair. If you like the idea, we could theoretically have just an embed tag inserted into google that then links to a GitHub pages site hosting all the static widget files on a different repo (I'd be happy to maintain that unless somebody else wants to) so that way it would be a separate project and could be removed easily if necessary. Let me know what you think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants