This repository has been archived by the owner on Nov 6, 2019. It is now read-only.
Fixed "has stacks" error tests failing on macOS 10.12.1 and node v7.0.0. #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All tests “has stack“ in errors.test.js failed on my mac running macOS 10.12.1 and node v7.0.0. Moving the call `Error.captureStackTrace(this, this.constructor)` after the name and message have been set solved the issue.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All tests “has stack“ in errors.test.js failed on my mac running macOS
10.12.1 and node v7.0.0.
Moving the call
Error.captureStackTrace(this, this.constructor)afterthe name and message have been set solved the issue.
I spent a lot of time trying to understand why this is happening, but I couldn't find a proper answer. In fact, all tests do pass on travis-ci running node 4.1, 4.2, 0.12, 0.10.