Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of symlinks for better Windows support #1410

Closed
wants to merge 1 commit into from
Closed

Conversation

tadatuta
Copy link
Member

@tadatuta
Copy link
Member Author

// cc @andrewblond it looks rather ugly :(

@tadatuta tadatuta mentioned this pull request Mar 18, 2015
@@ -1 +0,0 @@
../../simple.blocks/test/test.styl
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not to use borschik here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea how to use it here :(

// cc @andrewblond

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stylus and enb-stylus not support borschik, and will not be.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrewblond but how is freeze work now? What are the problems to use borschik for such cases?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably because of borschik (as post-processor) work will happen after pre-processor?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The last question is still relevant.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This "feature" of the enb-bem-examples: create symlinks, but does not change contents of files.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@blond can we decide this "feature" is a bug and fix it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is very difficult. It will be necessary to rewrite all the code around the enb-bem-examples.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

created issue enb/enb-bem-examples#14

@tadatuta
Copy link
Member Author

TODO: add comments and merge

@aristov
Copy link
Contributor

aristov commented Jun 11, 2015

@tadatuta ping

@aristov aristov closed this Jul 23, 2015
@aristov aristov deleted the issues/1200@v2 branch July 23, 2015 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants