New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix frame pointer manipulation #62

Open

rosshjb wants to merge 1 commit into below:main from rosshjb:frame-fix

Contributor

rosshjb commented Nov 5, 2024 •

edited

Loading

Two changes were made:

In the original code, frame pointer FP is changed to point to SP, but it doesn't be restored to original value in the end — the FP is a callee-saved register. So, we should save an existing FP value and restore the value later.
The FP points to top of stack frame. So the FP should refer the variables inside the frame with non-negative offset.


          fix: fix frame pointer manipulation

daa57b0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet