Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci static code analysis improvement #43

Merged

Conversation

wildanie12
Copy link
Member

this closes #42

Deskripsi (Description)

Yang dilakukan

  • Merubah command execution untuk code linting
  • Implementasi timeout untuk code linting, terkadang bisa lama di local (tergantung hardware), dibuat universal 10 menit
  • Formatted sesuai rule dari gofmt
  • Fix syntax error di basic/13_slice/slice.go

Checklist:

Umum:
  • Saya menambah algoritma terbaru.
  • Saya memperbaiki algoritma yang sudah ada.
  • Saya memperbaiki dokumentasi.
  • Saya menambah dokumentasi.
  • Saya memperbarui workflow continuous integration.
  • Saya memperbaiki materi yang sudah ada.
Contributor Requirements (Syarat Kontributor) dan Lain-Lain:
  • Saya sudah membaca (I have read) CONTRIBUTING dan sudah menyetujui semua syarat.
  • Saya telah menambahkan docstring yang memberikan penjelasan maksud dari kode yang saya buat.
  • Saya menggunakan bahasa Indonesia untuk memberikan penjelasan dari kode yang saya buat.

Environment

Saya menggunakan (I'm using):

  • os = linux ubuntu (WSL)
  • Go version = go 1.20.4 linux/amd64

linked issue #42

@wildanie12 wildanie12 marked this pull request as draft February 10, 2024 11:40
@wildanie12
Copy link
Member Author

dev log:
masih oncheck & fix issue untuk ignore error ini
image

di local terpantau tdk ada error (golangci-lint version v1.51.0)

@slowy07
Copy link
Member

slowy07 commented Feb 10, 2024

kyknya mungkin lebih baik di ignore aja @wildanie12 👍🏻 💯

@wildanie12
Copy link
Member Author

wildanie12 commented Feb 10, 2024

fixed sens, @slowy07. ready to review 🚩
unit testing & linting msh bisa dipertahanin

@wildanie12 wildanie12 marked this pull request as ready for review February 10, 2024 12:14
Copy link
Member

@rulanugrh rulanugrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

omo :u, keren mas @wildanie12 👍 , berarti pull request yang sebelumnya dilakukan pull request ulang saja ya mas

@wildanie12
Copy link
Member Author

yoi tentu @rulanugrh . thanks 👍

@wildanie12 wildanie12 merged commit c4cf3c7 into main Feb 10, 2024
3 checks passed
Copy link
Member

@slowy07 slowy07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice one @wildanie12

@wildanie12 wildanie12 deleted the feature/wildan/issue-42-ci-static-code-analysis-improvement branch February 10, 2024 13:46
@slowy07
Copy link
Member

slowy07 commented Feb 10, 2024

next mungkin bisa upgrade ke actions/setup-go@v4 untuk setup golangnya @wildanie12 💯

@wildanie12
Copy link
Member Author

will do, thx sens @slowy07

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Golang files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improvement on static code analysis
3 participants