Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Relay2Header toString() format #730

Closed
wants to merge 1 commit into from

Conversation

pruivo
Copy link
Collaborator

@pruivo pruivo commented Jun 29, 2023

No description provided.

@pruivo pruivo requested a review from belaban June 29, 2023 13:47
@pruivo pruivo changed the title Fix Relay2Header toString() forma format Fix Relay2Header toString() format Jun 29, 2023
Copy link
Owner

@belaban belaban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I dont like the change, as I do not want to show sites or visited_sites when they're null or empty. Besides, I changed this in the JGRP-2706 branch already

@pruivo
Copy link
Collaborator Author

pruivo commented Jun 29, 2023

why is that?

@belaban
Copy link
Owner

belaban commented Jun 29, 2023

Only show essential stuff, to not confuse the user

@belaban
Copy link
Owner

belaban commented Jun 29, 2023

Wait for my fix in 2706! Cheers :-)

@pruivo pruivo closed this Jun 29, 2023
@pruivo pruivo deleted the t_relay2header_tostring branch June 29, 2023 17:02
@pruivo pruivo restored the t_relay2header_tostring branch June 29, 2023 17:02
@pruivo pruivo deleted the t_relay2header_tostring branch June 29, 2023 17:02
@pruivo pruivo restored the t_relay2header_tostring branch June 29, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants