Rework of the World crate! #69
Conversation
|
I would have liked to implement biomes before i made this PR ready but i have sadly ran low on time and motivation 😅. This is a fully stable implementation to interact with the level. The code is also quite generic; this may lead to generic hell but the library provides powerful default types (at least in my opinion) so users should never have to interact with generic hell! |
| let wld_path = std::fs::read_to_string("world_path.txt").ok(); | ||
| if wld_path.is_none() { | ||
| println!( | ||
| "Skipping Full Test, Add \"world_path.txt\" next to the Cargo.toml with a world path!" |
There was a problem hiding this comment.
Why not just upload an entire world to github for the sake of proper testing?
There was a problem hiding this comment.
I dont really like the idea of having a massive binary file pushed into the github. It also makes testing the codebase easier.
There was a problem hiding this comment.
Its commin practice to upload such files if needed for testing, so dw.. example: nbtx
This is a significant pull request, so I apologize in advance.
I am currently working on a rewrite of the World crate in BedrockRS to enhance its features and modularity. While this PR is still a work in progress and there are several changes I plan to make, I would greatly appreciate input from the maintainers regarding the code.