draft:[SW-1239] Expose body_height parameter in velocity_cmd() #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcappellari-bdai
requested review from
jbarry-bdai,
heuristicus,
amessing-bdai and
khughes-bdai
as code owners
Pull Request Test Coverage Report for Build 10064249892Details
💛 - Coveralls |
tcappellari-bdai
changed the title
tcappellari-bdai
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposed the
body_heightparameter in thevelocity_cmd()method to allow users to specify the height of Spot as it moves.EEP requested this feature to use with their new controllers. Previously, the height would reset back to a default of 0 whenever velocity commands were sent.
(still working on driver part - meant to leave this as a draft for now)