Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .depend #1079

Merged
merged 1 commit into from
Nov 5, 2024
Merged

Update .depend #1079

merged 1 commit into from
Nov 5, 2024

Conversation

tleedjarv
Copy link
Contributor

Add missing dependencies that broke parallel builds. Non-parallel builds are not impacted.

Fixes #1078

@gdt
Copy link
Collaborator

gdt commented Nov 5, 2024

I'm not averse to this, but I'm having trouble following and I'd like to get unconfused. I do understand the point of having a dependency expressed. I ran "gmake -j50" without issues -- but I don't have the GUI prereqs. However, my build output doesn't look parallel. Are you simply doing "${GMAKE} -j16" at top level?

@tleedjarv
Copy link
Contributor Author

I'm not averse to this, but I'm having trouble following and I'd like to get unconfused. I do understand the point of having a dependency expressed. I ran "gmake -j50" without issues -- but I don't have the GUI prereqs.

These are make dependencies, not build prereqs.

However, my build output doesn't look parallel. Are you simply doing "${GMAKE} -j16" at top level?

Yes. It's not going to be massively parallel (just look at the list of dependencies in .depend). Just compare the ouput with that of -j1 and you'll see a difference.

@gdt
Copy link
Collaborator

gdt commented Nov 5, 2024

I meant that without the GUI prereqs installed, the build system doesn't build unison-gui and hence doesn't get into pixmap in the first place.

Indeed the diff is different. It's just that I am used to BSD make which makes parallel operation much more apparent.

@gdt gdt merged commit 5aae67c into bcpierce00:master Nov 5, 2024
28 checks passed
@tleedjarv tleedjarv deleted the fix-1078 branch November 5, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pixmaps.ml: Error: Unbound module Bytearray
2 participants