Remove fid support

bbc · Sep 2, 2024 · d83ad04 · d83ad04
1 parent 8ab7495
commit d83ad04
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 14 deletions.
diff --git a/src/index.js b/src/index.js
@@ -16,7 +16,7 @@ const webVitalsBase = {
   url: 'current-page-url',
 };
 
-const vitals = { cls: null, fid: null, lcp: null, fcp: null, ttfb: null };
+const vitals = { cls: null, lcp: null, fcp: null, ttfb: null };
 const deviceMetrics = {
   device_mem: null,
   device_cpu: null,
@@ -136,7 +136,6 @@ const useWebVitals = ({
         deviceMemory,
       });
       onCLS(updateWebVitals, { reportAllChanges: true });
-      onFID(updateWebVitals);
       onLCP(updateWebVitals, { reportAllChanges: true });
       onFCP(updateWebVitals);
       onTTFB(updateWebVitals);

diff --git a/src/index.test.js b/src/index.test.js
@@ -16,11 +16,10 @@ const mockVitalsGet = (name, value) => reportHandler => {
 };
 
 webVitals.onCLS.mockImplementation(mockVitalsGet('CLS', 1));
-webVitals.onFID.mockImplementation(mockVitalsGet('FID', 2));
-webVitals.onLCP.mockImplementation(mockVitalsGet('LCP', 3));
-webVitals.onFCP.mockImplementation(mockVitalsGet('FCP', 4));
-webVitals.onTTFB.mockImplementation(mockVitalsGet('TTFB', 5));
-webVitals.onINP.mockImplementation(mockVitalsGet('INP', 6));
+webVitals.onLCP.mockImplementation(mockVitalsGet('LCP', 2));
+webVitals.onFCP.mockImplementation(mockVitalsGet('FCP', 3));
+webVitals.onTTFB.mockImplementation(mockVitalsGet('TTFB', 4));
+webVitals.onINP.mockImplementation(mockVitalsGet('INP', 5));
 
 let eventListeners = {};
 
@@ -79,7 +78,6 @@ describe('useWebVitals', () => {
       renderHook(() => useWebVitals({ enabled }));
 
       expect(webVitals.onCLS).toHaveBeenCalled();
-      expect(webVitals.onFID).toHaveBeenCalled();
       expect(webVitals.onLCP).toHaveBeenCalled();
       expect(webVitals.onFCP).toHaveBeenCalled();
       expect(webVitals.onTTFB).toHaveBeenCalled();
@@ -181,7 +179,6 @@ describe('useWebVitals', () => {
       renderHook(() => useWebVitals({ enabled, reportingEndpoint }));
 
       expect(webVitals.onCLS).toHaveBeenCalled();
-      expect(webVitals.onFID).toHaveBeenCalled();
       expect(webVitals.onLCP).toHaveBeenCalled();
       expect(webVitals.onFCP).toHaveBeenCalled();
       expect(webVitals.onTTFB).toHaveBeenCalled();
@@ -194,11 +191,10 @@ describe('useWebVitals', () => {
           type: 'web-vitals',
           body: expect.objectContaining({
             cls: 1,
-            fid: 2,
-            lcp: 3,
-            fcp: 4,
-            ttfb: 5,
-            inp: 6,
+            lcp: 2,
+            fcp: 3,
+            ttfb: 4,
+            inp: 5,
           }),
         }),
       ];