Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade sbt to 1.7.2 #66

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

chris-s-thompson
Copy link
Contributor

What?

Upgrade the SBT version from 1.5.2 to 1.7.2

Why?

Keep-up with security fixes to the SBT build tool, alongside enhanced support for Scala 2.13.x projects

@chris-s-thompson
Copy link
Contributor Author

I have tested the upgrade by running the 'compile', 'run' and 'test' tasks, which all seem to be working ok.

Copy link
Contributor

@paulbrimicombe paulbrimicombe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tried this locally and it looks fine to me.

@@ -1 +1 @@
sbt.version=1.5.2
sbt.version=1.7.2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interestingly I can't get it to work with anything newer than 1.7.2 because of some dependency conflicts.

mattmouldbbc added a commit that referenced this pull request May 10, 2023
…#66 (#98)

* Remove async/await from the allCandidates code for consistency with PR #66
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants