Get tests running & give pseudocode in tests like Java assessment #109
Conversation
twinlensreflex
changed the title
| @@ -45,7 +45,6 @@ class ResultsController @Inject()(val controllerComponents: ControllerComponents | |||
| } | |||
|
|
|||
| def getScoreboard: Action[AnyContent] = Action { | |||
|
|
|||
| Ok(Json.toJson(Scoreboard(0))) | |||
| Ok(Json.toJson(None)) | |||
There was a problem hiding this comment.
From what I recall from Python & Java, this is "supposed" to fail to begin with because Scoreboard isn't adequately implemented/integrated yet. I'm not sure that's the right way but it is consistent
| // - the overall winner (if there is one) | ||
| // - the seats that each party wins in Parliament | ||
| case class Scoreboard(winner: String) |
There was a problem hiding this comment.
Do you want winner parameter here? Feels like prejudicing the approach taken...
| ### Possible other implementations | ||
|
|
||
| - Absolute majority required. Someone needs 50% + 1 votes or a run off is triggered (check the data that's probably all constituencies) | ||
| - Allocate the seats from the total declarations based on % of vote share |
There was a problem hiding this comment.
Agree, the whole "other implementations" section looking at other voting systems is a bad idea (but! for fairness/consistency we should edit tasks.md for other languages)
| // LD == 62 | ||
| // LAB == 349 | ||
| // CON == 210 | ||
| // winner = LAB | ||
| } |
There was a problem hiding this comment.
👍 on having comments stating assertions needed & letting the candidate implement (as in other languages)
| @@ -21,7 +21,7 @@ The API has 3 endpoints: | |||
|
|
|||
| During your assessment we will ask you to work though the task in `tasks.md` with a pair. Please do not work on or complete these prior to the assessment. | |||
|
|
|||
| :warning: If you make any changes to the code, please ensure you return it to it's initial (HEAD) state before your assessment. | |||
| __Warning:__ If you make any changes to the code, please ensure you return it to it's initial (HEAD) state before your assessment. | |||
There was a problem hiding this comment.
it's initial state
Its. Not it's. Oh dear.
|
In my opinion:
|
What?
Why?