Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEST install setuptools #42

Closed
wants to merge 1 commit into from
Closed

Conversation

philipnbbc
Copy link
Contributor

Details

Tests that the changes from https://github.com/bbc/rd-cloudfit-commontooling/pull/306 works

Pivotal Story

Story URL:

Related PRs

Requires https://github.com/bbc/rd-cloudfit-commontooling/pull/306

Links to external test runs/working deployment

Where appropriate, if separate to default CI run

Submitter PR Checks

(tick as appropriate)

  • PR completes task/fixes bug
  • Tests exercise code appropriately
  • New features and API breaks are flagged in commit messages using magic strings
  • Documentation updated (README, Confluence, Docstrings, API spec, Engineering Guide, etc.)
  • Downstream repos have been checked for potential breaks & fixed as needed
  • APIs/UIs/CLIs updated as required
  • PR added to Pivotal story
  • Follow-up stories added to Pivotal
  • Any temporary code/configuration removed (e.g. test deployment environment, temporary commontooling branch)
  • Any pins against pre-releases have been removed

Reviewer PR Checks

(tick as appropriate)

  • PR completes task/fixes bug
  • Tests exercise code appropriately
  • Design makes sense, and fits with our current code base
  • Code is easy to follow
  • PR size is sensible
  • Commit history is sensible and tidy

Info on Cloudfit PRs

@philipnbbc philipnbbc requested a review from a team as a code owner September 5, 2024 09:44
@philipnbbc philipnbbc force-pushed the philipn-install-python-setuptools branch from 05f0da1 to d615ac3 Compare September 5, 2024 09:48
@philipnbbc philipnbbc force-pushed the philipn-install-python-setuptools branch from d615ac3 to 99b9942 Compare September 5, 2024 10:03
@philipnbbc philipnbbc closed this Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant