Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce compatibility with python3 #18

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MichalKrasowski
Copy link

@MichalKrasowski MichalKrasowski commented Jul 16, 2018

fixes #4

Done by launching 2to3 in dvbcss directory.
I have also manually added guard for exceptions module, that is a built-in in python3.

@MichalKrasowski MichalKrasowski changed the title changes to introduce compatibility with python3 introduce compatibility with python3 Jul 16, 2018
@MichalKrasowski
Copy link
Author

MichalKrasowski commented Jul 16, 2018

Please don't merge yet, some tests are failing.

@matt-hammond-001
Copy link
Contributor

matt-hammond-001 commented Jul 16, 2018

Thanks for doing work on this!

It would be great if the code in the examples directory could also converted to python3 compatibility as part of this branch.

Also it looks like the change to the import queue statement in task.py will break compatibility with python2. It would be preferable for the code to be both python 2 and python 3 compatible.

@MichalKrasowski
Copy link
Author

Also it looks like the change to the import queue statement in task.py will break compatibility with python2.

I can see even more problems with my change. It looks like that in my use-case I would also have to update the dvbcss-synctiming repo. I don't know if I will have the time for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not yet python 3 compatible
2 participants