-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge latest Guardian changes as of 18-04-2024 #270
Commits on Mar 1, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 45af0d6 - Browse repository at this point
Copy the full SHA 45af0d6View commit details
Commits on Mar 2, 2024
-
Configuration menu - View commit details
-
Copy full SHA for afbb983 - Browse repository at this point
Copy the full SHA afbb983View commit details -
Configuration menu - View commit details
-
Copy full SHA for 799a821 - Browse repository at this point
Copy the full SHA 799a821View commit details -
...and fix byline I broke in previous commit, yeah, I dont know how to pretend I haven't
Configuration menu - View commit details
-
Copy full SHA for 24cb6e1 - Browse repository at this point
Copy the full SHA 24cb6e1View commit details
Commits on Mar 7, 2024
-
Configuration menu - View commit details
-
Copy full SHA for ddb931d - Browse repository at this point
Copy the full SHA ddb931dView commit details
Commits on Mar 8, 2024
-
Add to all pills in Info panel…
…this UGLY repetition of js bits will need to be removed
Configuration menu - View commit details
-
Copy full SHA for 53e8cfb - Browse repository at this point
Copy the full SHA 53e8cfbView commit details -
Add to Label pills on thumbnails…
…I don’t like the hardcoding of 'label', but elementName is missing (bug?)
Configuration menu - View commit details
-
Copy full SHA for bdfd175 - Browse repository at this point
Copy the full SHA bdfd175View commit details -
…yet another repetition, will remove once I know how
Configuration menu - View commit details
-
Copy full SHA for ce1d636 - Browse repository at this point
Copy the full SHA ce1d636View commit details
Commits on Apr 9, 2024
-
IMAGEDAM-1593 - WIP Changes to syndication request and usage metadata…
… to support a send to capture syndication. Still need to make changes to the syndication endpoint itself and test via postman
Configuration menu - View commit details
-
Copy full SHA for 31fd2f6 - Browse repository at this point
Copy the full SHA 31fd2f6View commit details -
IMAGEDAM-1593 - Further changes to syndication functionality
Added syndicated parameter to syndication metadata in the SyndicationUsageRequest. Builders in UsageGroup and UsageIdBuilder were amended to include new syndicatedBy parameter
Configuration menu - View commit details
-
Copy full SHA for e81f68d - Browse repository at this point
Copy the full SHA e81f68dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5ec545f - Browse repository at this point
Copy the full SHA 5ec545fView commit details -
Configuration menu - View commit details
-
Copy full SHA for abe709f - Browse repository at this point
Copy the full SHA abe709fView commit details -
IMAGEDAM-1593 - Updating ElasticSearch with new usage status WIP
Currently, the usage status update successfully updates dynamoDB but not ElasticSearch. In order for ElasticSearch to be updated, the correct message, containing an updated UsageNotice must be published to Thrall, via kinesis. Thrall will then process this message and run a script that will update ElasticSearch. The 'plumbing' for flow has been added, all that is left is to implement the functionality to update ElasticSearch
Configuration menu - View commit details
-
Copy full SHA for 7b77fe5 - Browse repository at this point
Copy the full SHA 7b77fe5View commit details -
IMAGEDAM-1593 - Updating ElasticSearch with new usage status WIP pt2
Further additions to the ElasticSearch file, specifically the UpdateSingleUsageMessage function. Attempted to pass usageId and usageParameters in as two tuples as 'prepareUpdateRequest' suggests that the 'params' input can have variable arguments, but was getting a syntax error. Instead choosing to just pass in usageParameters and accessing the usageId from there (if this works can remove usageId from previous functions). Some modification to the script still required I think, tested with current changes and usage status is still not updating.
Configuration menu - View commit details
-
Copy full SHA for 2db29fb - Browse repository at this point
Copy the full SHA 2db29fbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 53c8c32 - Browse repository at this point
Copy the full SHA 53c8c32View commit details -
IMAGEDAM-1593 - Updating ElasticSearch with new usage status WIP pt2.2
It seems like the painless script is very particular with how it is written, but currently this works without an error. The script is not complete though as the parameters are being sent as Options, which painless doesn't know how to handle, so it doesn't work as expected
Configuration menu - View commit details
-
Copy full SHA for df28a03 - Browse repository at this point
Copy the full SHA df28a03View commit details -
IMAGEDAM-1593 - Updating ElasticSearch with new usage status WIP pt2.3
Params are still being sent through as Options, some difficulty in fixing this. Seems that root cause is that the play framework doesn't know how to serialise/deserialise a 'UsageNotice' as Read/Write implicits have not been defined for it. There are a few potential options to fix this. 1. Add the required implicits to UsageNotice (perhaps not desirable as would be repeated code from Usages class) 2. Refactor ThrallMessageSender to make use of Usage (or potentially MediaUsage so that we use a class it knows how to handle) 3. Copy the pattern used for the 'updateUsage' existing method, clearly can handle params properly there as they are used in that function 4. Least desirable, get the update working for the status only case which involves just two parameters, which can be unwrapped from options fairly easily, but wouldn't be applicable for generic case
Configuration menu - View commit details
-
Copy full SHA for 0ef5271 - Browse repository at this point
Copy the full SHA 0ef5271View commit details -
IMAGEDAM-1593 - Updating ElasticSearch with new usage status WIP pt2.4
Completed the work that allows for an individual usage status to be updated. The issue with Options being passed into the painless script turned out to not be the source of my problems, I was actually accessing the parameters incorrectly, with this resolved the script worked without any issues. Also cleaned up the code changes, renaming functions and parameters, so they are accurate and removing various print statements added for debugging.
Configuration menu - View commit details
-
Copy full SHA for adb1930 - Browse repository at this point
Copy the full SHA adb1930View commit details -
IMAGEDAM-1593 - Updating ElasticSearch with new usage status WIP pt2.5
Added 'lastModified' update to the update usage status painless script
Configuration menu - View commit details
-
Copy full SHA for 7c499d1 - Browse repository at this point
Copy the full SHA 7c499d1View commit details -
IMAGEDAM-1593 - Amending updateUsageStatus endpoint to be asynchronous
Use of 'queryByUsage' meant that a Future[Status] was returned by this endpoint instead of the 'Result' type, required 'Authentication.request'. A placeholder return status was originally included so that this wouldn't block development, but once the desired functionality was achieved a permanent solution was desired. This solution was to make the endpoint explicitly asynchronous, by using 'async.auth', by default this corrected the success case and the failure case was solved by wrapping the output in a Future[]
Configuration menu - View commit details
-
Copy full SHA for fa8bca4 - Browse repository at this point
Copy the full SHA fa8bca4View commit details -
IMAGEDAM-1593 - Last modified date additional logic & syndication met…
…adata in mapping test
Configuration menu - View commit details
-
Copy full SHA for f2f627d - Browse repository at this point
Copy the full SHA f2f627dView commit details -
Configuration menu - View commit details
-
Copy full SHA for f0427e8 - Browse repository at this point
Copy the full SHA f0427e8View commit details -
IMAGEDAM-1593 - Changing from nonDynamicObjectField to dynamicObj to …
…resolve 'strict_dynamic_mapping_exception'
Configuration menu - View commit details
-
Copy full SHA for 6ac8096 - Browse repository at this point
Copy the full SHA 6ac8096View commit details -
Configuration menu - View commit details
-
Copy full SHA for 73ebd2e - Browse repository at this point
Copy the full SHA 73ebd2eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 890d671 - Browse repository at this point
Copy the full SHA 890d671View commit details -
Configuration menu - View commit details
-
Copy full SHA for ae77a5f - Browse repository at this point
Copy the full SHA ae77a5fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3c73176 - Browse repository at this point
Copy the full SHA 3c73176View commit details -
Configuration menu - View commit details
-
Copy full SHA for cd0a5cd - Browse repository at this point
Copy the full SHA cd0a5cdView commit details
Commits on Apr 10, 2024
-
Merge pull request guardian#4244 from bbc/conal/IMAGEDAM-1593-sendToC…
…aptureSyndication Conal/imagedam 1593 send to capture syndication
Configuration menu - View commit details
-
Copy full SHA for c291bfd - Browse repository at this point
Copy the full SHA c291bfdView commit details
Commits on Apr 11, 2024
-
The `push-pr` workflow (added in guardian#4240) hasn't been triggering CI as it was created to do, this should fix it...
Configuration menu - View commit details
-
Copy full SHA for ce5c127 - Browse repository at this point
Copy the full SHA ce5c127View commit details -
Merge pull request guardian#4260 from guardian/trigger-CI-for-pr-bran…
…ches trigger CI for `pr*` branches
Configuration menu - View commit details
-
Copy full SHA for 20db9e4 - Browse repository at this point
Copy the full SHA 20db9e4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0e63b27 - Browse repository at this point
Copy the full SHA 0e63b27View commit details -
Merge pull request guardian#4262 from guardian/gha/improve_run_name_f…
…or_push-pr improve 'run name' for `push-pr` GHA workflow runs
Configuration menu - View commit details
-
Copy full SHA for b3319ab - Browse repository at this point
Copy the full SHA b3319abView commit details
Commits on Apr 12, 2024
-
Configuration menu - View commit details
-
Copy full SHA for e618211 - Browse repository at this point
Copy the full SHA e618211View commit details -
Configuration menu - View commit details
-
Copy full SHA for 768ad9e - Browse repository at this point
Copy the full SHA 768ad9eView commit details
Commits on Apr 15, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 0dd3917 - Browse repository at this point
Copy the full SHA 0dd3917View commit details -
Merge pull request guardian#4252 from guardian/an/include-exclude-met…
…adata [feature] Hold Alt to exclude, Shift to include when clicking search links
Configuration menu - View commit details
-
Copy full SHA for 95cdbd9 - Browse repository at this point
Copy the full SHA 95cdbd9View commit details