Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing commandline output file arg in docs #93

Merged
merged 2 commits into from
Aug 30, 2024
Merged

Fix missing commandline output file arg in docs #93

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
024a271
docs: Add missing -o options in raw2bmx command examples
philipnbbc Aug 30, 2024
e2b99b5
apps: Output error message if no output name is given
philipnbbc Aug 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions apps/bmxtranswrap/bmxtranswrap.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3568,6 +3568,11 @@ int main(int argc, const char** argv)
log_info("Output filename set to '%s'\n", complete_output_name.c_str());
}

if (complete_output_name.empty()) {
log_error("No output name given; use the '-o' option\n");
throw false;
}


// create output clip and initialize

Expand Down
11 changes: 5 additions & 6 deletions apps/raw2bmx/raw2bmx.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4113,12 +4113,6 @@ int main(int argc, const char** argv)
return 1;
}

if (!output_name) {
usage_ref(argv[0]);
fprintf(stderr, "No output name given\n");
return 1;
}

if (inputs.empty()) {
usage_ref(argv[0]);
fprintf(stderr, "No raw inputs given\n");
Expand Down Expand Up @@ -4997,6 +4991,11 @@ int main(int argc, const char** argv)
log_info("Output filename set to '%s'\n", complete_output_name.c_str());
}

if (complete_output_name.empty()) {
log_error("No output name given; use the '-o' option\n");
throw false;
}


// create clip

Expand Down
4 changes: 2 additions & 2 deletions docs/timed_text.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,13 +36,13 @@ The `raw2bmx` utility can be used to embed Timed Text XML and ancillary font or
*Example 1*: Creates an OP1a file including a timed text track alongside video and audio tracks. The manifest file, `manifest.txt`, references the Timed Text XML file and ancillary resource files.

```bash
raw2bmx -t op1a -y 10:00:00:00 --avci video.h264 --wave audio.wav --tt manifest.txt
raw2bmx -t op1a -o output.mxf -y 10:00:00:00 --avci video.h264 --wave audio.wav --tt manifest.txt
```

*Example 2*: Creates a (mono-essence) IMF Timed Text Track File. An edit rate (`-f`) and duration (`--dur`) are required in this case as they are not parsed from the Timed Text XML file (assuming they are specified in there).

```bash
raw2bmx -t imf -f 25 --dur 100 --tt manifest.txt
raw2bmx -t imf -o {Type}_{fp_uuid}.mxf -f 25 --dur 100 --tt manifest.txt
```

### Manifest File Format
Expand Down
Loading