Some growing file improvements #90
Conversation
A growing file may change the num samples when making the same request for a frame. E.g. the previous request may have returned 0 samples.
|
First test looks good Minor issue: is still printed out (even with |
Set the the MXF reader's mReadErrorMessage when less essence data is read from a file than was requested, but don't log the error. This avoids it being logged when reading a growing file where a later attempt succeeds. Note that this doesn't prevent non-essence read errors, e.g other KLVs.
I've added 7f27a4e that should avoid that error being printed. This only covers errors when reading essence data, which is the most likely error to happen if essence is large compared to the other KLV. There are other lower-level KLV errors that could occur that will still be logged because that's a limitation of libMXF/libMXF++. libMXF functions log errors and return a 0. Ideally libMXF would've had something similar to ferror/errno to propagate I/O errors up to clients which can decide to log it or not. |
Following issue reported in #87