Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal for hinting to Conan availability of bmx in the Readme #81

Merged
merged 2 commits into from
Jun 21, 2024

Conversation

irieger
Copy link
Contributor

@irieger irieger commented Jun 19, 2024

Hey,

with the recipe for bmx merged into the conan center index today, I thought I'd propose mentioning its availability in the Readme in case you want it mentioned.

A few general comments/updates, not really related to the actual content of the MR but as context.

As discussed in #80, on Winodws it is only available as a static library, other systems offer both. I myself already use it since a while on macOS (aarch64) and Linux (x64).

It offers Version 1.2 as it was the latest official release as well as cci.20240517. This follows a versioning scheme used in Conan for not officially tagged components. It was the state of the repo of bmx when all our build improvement suggestions had been merged. I'll keep watching bmx and will (try) to take care of updates when the next release is done etc.

Copy link
Collaborator

@philipnbbc philipnbbc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've suggested changes in inline comments and otherwise it looks good to me, thanks!

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@philipnbbc philipnbbc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@philipnbbc philipnbbc merged commit f61b837 into bbc:main Jun 21, 2024
5 checks passed
@irieger irieger deleted the conan-note branch July 11, 2024 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants