MXFDump: fix index out of bounds error #76
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #74 was (partially) replicated by building libMXF on Debian 11 with address sanitizer options as suggested for GCC here. However, no
global-buffer-overflow
error was reported; only a segmentation fault (e.g. shown when using justCXXFLAGS="-fsanitize=address"
).Additional installs required:
apt install libasan8 libubsan1
Build:
CXXFLAGS="-fsanitize=address -fsanitize=undefined -fno-sanitize-recover=all -fsanitize=float-divide-by-zero -fsanitize=float-cast-overflow -fno-sanitize=null -fno-sanitize=alignment" cmake -DCMAKE_BUILD_TYPE=Debug ../bmx/deps/libMXF
Running
MXFDump
onpoc.mxf
(provided in #74) results inFixes #74