Diagnose more possible const variables

bbannier · Dec 11, 2023 · 268294b · 268294b
1 parent fee8c19
commit 268294b
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 14 deletions.
diff --git a/rule-tests/__snapshots__/use-const-snapshot.yml b/rule-tests/__snapshots__/use-const-snapshot.yml
@@ -11,10 +11,6 @@ snapshots:
       style: secondary
       start: 11
       end: 14
-    - source: b""
-      style: secondary
-      start: 11
-      end: 14
     - source: global a = b"";
       style: secondary
       start: 0
@@ -30,10 +26,6 @@ snapshots:
       style: secondary
       start: 11
       end: 12
-    - source: '1'
-      style: secondary
-      start: 11
-      end: 12
     - source: global x = 1;
       style: secondary
       start: 0

diff --git a/rule-tests/use-const.yml b/rule-tests/use-const.yml
@@ -1,7 +1,6 @@
 id: use-const
 valid:
   - "global x: m::X;"
-  - "global x: m::X = [];"
   - "const x = 1;"
 invalid:
   - "global x = 1;"

diff --git a/rules/use-const.yml b/rules/use-const.yml
@@ -10,11 +10,6 @@ rule:
     has:
       field: "init"
       kind: "expression"
-      any:
-        - has:
-            kind: "bytes"
-        - has:
-            kind: "integer"
 
 fix: "const"