Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

workspace: Pay attention to members #3102

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

workspace: Pay attention to members #3102

wants to merge 2 commits into from

Conversation

illicitonion
Copy link
Collaborator

@illicitonion illicitonion commented Dec 14, 2024 •
edited
Loading

Previously we were ignoring this field and always doing auto-discovery.

Cargo only does auto-discovery if this field is not set.

Fixes #3090

@illicitonion
Depend on glob
51c9474
@illicitonion
workspace: Pay attention to members
61f7fb5 
Previously we were ignoring this field and always doing auto-discovery.

Cargo only does auto-discovery if this field is not set.
@illicitonion illicitonion mentioned this pull request Dec 14, 2024
Open
@jgsogo
Copy link
Contributor

jgsogo commented Dec 20, 2024

I arrived here from #3090 and tested with this patch applied on top of 89aec55 (current main HEAD). It works. Thanks a lot for the fix. Looking forward to a new release including these changes. 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UebelAndre UebelAndre Awaiting requested review from UebelAndre

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cargo-slice ignores members property of cargo workspaces
2 participants
@illicitonion @jgsogo