rust_analyzer: generate more reqired sources #3031
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing support for this has limitations: - only works for sources that are specially tagged (rust_generated_srcs). I've removed this mechanism as it's no longer needed. - only provides sources of the directly selected library, but rust-analyzer needs to parse its dependencies too. - is missing the target.json file, which rust-analyzer requires to parse the library (it invokes rustc --print cfg --target=...) The dependency depth to generate sources for is a tradeoff. More layers of deps will give more accurate analysis but be slower to generate. My guess is that in the end we'll want full transitive sources, but direct deps should be a non-controversial starting point. (Without these sources, rust-analyzer can't understand the direct API usage at all). We can change this later and probably need to reconcile with bazelbuild#3028.
|
The changes to rust_analyzer look good. I'm not sure if the It would be nice to add some tests to make sure that the expected sources are made available to the expected actions. |
krasimirgg
requested changes
Dec 11, 2024
There was a problem hiding this comment.
(sorry I left a comment in the wrong review state) The changes to rust_analyzer look good. I'm not sure if the rust_generated_srcs output group is used for anything else though?
It would be nice to add some tests to make sure that the expected sources are made available to the expected actions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing support for this has limitations:
I've removed this mechanism as it's no longer needed.
rust-analyzer needs to parse its dependencies too.
parse the library (it invokes rustc --print cfg --target=...)
The dependency depth to generate sources for is a tradeoff. More layers
of deps will give more accurate analysis but be slower to generate.
My guess is that in the end we'll want full transitive sources, but
direct deps should be a non-controversial starting point. (Without these
sources, rust-analyzer can't understand the direct API usage at all).
We can change this later and probably need to reconcile with #3028.