feat: add ability to change length of each segment (#15)

Recreated from and closes #12

---------

Co-authored-by: Sterling Cobb <[email protected]>

.github/workflows/ruby.yml

@@ -3,12 +3,10 @@ name: Ruby
 on:
   push:
     branches:
-      - main
-      - chore/upgrade-ruby-ci
+      - '*'
   pull_request:
     branches:
-      - main
-      - chore/upgrade-ruby-ci
+      - '*'
 
 jobs:
   test:

CHANGELOG.md

@@ -5,3 +5,6 @@
 
 ### 0.0.2
  - Bug fix `.validate` can't handle invalid characters and produces an error. (mrclmrvn)
+
+### 0.0.2
+ - add ability to specify length #15 (fourcolors)

README.md

@@ -48,6 +48,13 @@ You can change the number of parts of the generated code by passing an option ha
     >> CouponCode.validate("1K7Q-CTFM-LMTC-DLGP", 4)
     => "1K7Q-CTFM-LMTC-DLGP"
 
+You can also change the length of each part like:
+
+    >> CouponCode.generate(parts: 3, part_length: 5)
+    => "GRG65-X0PF4-KP7TJ"
+    >> CouponCode.validate("1K7Q-CTFM-LMTC-DLGP", 3, 5)
+    => "1K7Q-CTFM-LMTC-DLGP"
+
 ## Testing
 
 ```ruby

lib/coupon_code.rb

@@ -7,25 +7,27 @@ module CouponCode
   PARTS = 3
   LENGTH = 4
 
-  def self.generate(options = {parts: PARTS})
+  def self.generate(options = {parts: PARTS, part_length: LENGTH})
     num_parts = options.delete(:parts)
+    length_of_parts = options.delete(:part_length) || LENGTH
+
     parts = []
     (1..num_parts).each do |i|
       part = ""
-      (1...LENGTH).each { part << random_symbol }
+      (1...length_of_parts).each { part << random_symbol }
       part << checkdigit_alg_1(part, i)
       parts << part
     end
     parts.join("-")
   end
 
-  def self.validate(orig, num_parts = PARTS)
+  def self.validate(orig, num_parts = PARTS, part_length = LENGTH)
     code = orig.upcase
     code.gsub!(/[^#{SYMBOL}]+/o, "")
-    parts = code.scan(/[#{SYMBOL}]{#{LENGTH}}/o)
+    parts = code.scan(/[#{SYMBOL}]{#{part_length}}/)
     return if parts.length != num_parts
     parts.each_with_index do |part, i|
-      data = part[0...(LENGTH - 1)]
+      data = part[0...(part_length - 1)]
       check = part[-1]
       break if check != checkdigit_alg_1(data, i + 1)
     end

lib/coupon_code/version.rb

@@ -1,3 +1,3 @@
 module CouponCode
-  VERSION = "0.0.2".freeze
+  VERSION = "0.0.3".freeze
 end

spec/coupon_code_spec.rb

@@ -15,13 +15,24 @@
       subject { described_class.generate(parts: 2) }
       it { is_expected.to match(/^\w{4}-\w{4}$/) }
     end
+
+    context "when passed part_length" do
+      subject { described_class.generate(part_length: 4, parts: 1) }
+      it "allows part length to be set" do
+        expect(subject.length).to equal(4)
+      end
+    end
   end
 
   describe ".validate" do
     it "validates a good code" do
       expect(described_class.validate("1K7Q-CTFM-LMTC")).to eq("1K7Q-CTFM-LMTC")
     end
 
+    it "validates with a custom length" do
+      expect(described_class.validate("GRG65-X0PF4-KP7TJ", 3, 5)).to eq("GRG65-X0PF4-KP7TJ")
+    end
+
     it "validates and returns the code in uppercase letters" do
       expect(described_class.validate("1K7Q-ctfm-LMTC")).to eq("1K7Q-CTFM-LMTC")
     end