Add exhaustive match #26
Conversation
|
Need to add the same option to |
baweaver
force-pushed
the
baweaver/exhaustive_match
branch
from
c108f53
to
e8d7d01
Compare
|
Added a few more enhancements to the idea to provide better error messages, as well as a pessimistic and optimistic version of failure. Thoughts? |
| # | ||
| # @return [Boolean] | ||
| def all_branches_provided? | ||
| available_branch_names == @provided_matchers.uniq |
There was a problem hiding this comment.
May fail if you provide branches in order other than order of registration
| available_branch_names == @provided_matchers.uniq | |
| available_branch_names.sort == @provided_matchers.uniq.sort |
or you can store names as an instance of Set
There was a problem hiding this comment.
I tried to integrate latest changes into my PR, and got this error:
Qo::Exceptions::ExhaustiveMatchMissingBranches:
Exhaustive match required: pattern does not specify all branches.
Expected Branches: right, left
Given Branches: left, rightThere was a problem hiding this comment.
I may jump back to implementing this with sets, silly mistake on my part.
| # | ||
| # @author baweaver | ||
| # @since 0.99.1 | ||
| class ExhaustiveMatchMissingBranches < StandardError |
There was a problem hiding this comment.
I suggest having common ancestor for all Qo errors and, probably for exhaustive match errors. So end users will be able to catch errors with desired granularity. For example Qo::Error, Qo, MatchError, ExhaustiveMatchNotMet etc.
Adds the idea of an exhaustive match to the API that will fail if a match has not been found as a response to #25