Fix bug in evaluation for tie in scores. #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So this change would require re-evaluating all checkpoints and updating the reported numbers in the README, right? |
|
I just reviewed batra-mlp-lab/visdial#36 and tried simplifying things a bit: batra-mlp-lab/visdial@3a769d2. Those changes probably apply here too. |
|
@nirbhayjm yes it does. If we never faced ties in scores, then they won't change. But usually there are ties... |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the score of ground truth would tie with another option, it always got assigned a higher rank. This caused evaluation metrics to be reported higher than their true values. This PR fixes that.