Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hash for devilutionx #12996

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DavisNT
Copy link
Contributor

@DavisNT DavisNT commented Nov 28, 2024

The devilutionx-src.tar.xz is probably generated during DevilutionX release and its hash for a particular DevilutionX version shouldn't change over time.

This change has been tested in several full clean builds (make rk3326-cleanbuild).

The devilutionx-src.tar.xz is probably generated during DevilutionX
release and its hash for a particular DevilutionX version shouldn't
change over time.
@dmanlfc
Copy link
Collaborator

dmanlfc commented Nov 28, 2024

i would rather we didn't tbh. it's just extra maintenance on updates.
you'll notice many third-party packages in batocera we don't bother.
why do you think it's super necessary apart from the obvious?

@n2qz
Copy link
Contributor

n2qz commented Nov 28, 2024

@DavisNT If I understand correctly, your intention here is to deal with the name of the source archive staying the same when the version changes. When that happens, a new version may not be downloaded as intended. If the hash doesn't match, Buildroot should download a new revision.

If that's the intention, a better approach (with or without the hash validation) would be to store each downloaded version in a directory containing the version number, something like this:

DEVILUTIONX_DL_DIR = $(BR2_DL_DIR)/devilutionx-$(DEVILUTIONX_VERSION)

@DavisNT
Copy link
Contributor Author

DavisNT commented Nov 29, 2024

@n2qz When the version is bumped the download URL changes, I haven't tested whether buildroot handles this correctly.

The reason I would like to add the hash is for security (in case existing releases would get maliciously modified, we would know) and stability (in the rare event something gets changed by authors, we would know).

DevilutionX is not special in any way here. I made this PR because when my build of clean master branch failed due to incorrect devilutionx hash and I asked in Discord whether the hash needs to be updated it got removed altogether.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants