replace commas with dots in controller.realName fixing non-working controller configurations #12194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntroller configurations
|
@nadenislamarre one for you. this will upset the existing controller configs. |
|
yes, i have to analyze first, while replacing coma is more a workaround than a fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Controllers with device names that contain a comma refuse to load properly when emulators such as pcsx2 are used. The game_controller_db.txt appears to parse a comma delimited file and fails because of said erroneous comma placements. This patch will simply replace said commas with dots.
Tested and working after this simple change.
Refer to #8568 with the poster who made the discovery. They had the same issue with the ppsspp emulator.