Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: fix some typos #173

Merged
merged 1 commit into from
Feb 24, 2020
Merged

README: fix some typos #173

merged 1 commit into from
Feb 24, 2020

Conversation

enkore
Copy link
Contributor

@enkore enkore commented Feb 24, 2020

No description provided.

@@ -100,17 +100,17 @@ You can use this to launch automatically supervised tasks.
* Kill your application in certain condition or restart you subprocesses whenever a certain condition is met.

## Guarantees
Copy link
Contributor Author

@enkore enkore Feb 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the items under this heading don't seem like guarantees to me, e.g. "completely asynchronous system design" is more of a feature that might imply certain guarantees. "Asynchronous program boundaries" also seems entirely like a feature to me, ditto for "dynamic supervision ..."

Copy link
Contributor

@o0Ignition0o o0Ignition0o Feb 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's very true, maybe we can open a followup issue to discuss it ?

edit: opened a followup issue :)

Copy link
Contributor

@o0Ignition0o o0Ignition0o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there, thanks for the pull request!

As you may have understood, most of us aren't english native, so typo fixes are more than appreciated!

It looks good to me, I'll wait for the CI to pass to merge it!

:shipit: 🚀 🎉

@o0Ignition0o o0Ignition0o merged commit 514e4a0 into bastion-rs:master Feb 24, 2020
@enkore enkore deleted the patch-1 branch February 26, 2020 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants