Added missing javadoc documentation for GlobalRequestAttributes class #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KPull
reviewed
Oct 25, 2017
| public GlobalRequestAttributes timeout(long timeout) { | ||
| requireNonNull(timeout, "timeout should not be null."); |
There was a problem hiding this comment.
Since timeout is a primitive type, it cannot be null so there's no need for this check.
There was a problem hiding this comment.
replaced it with a more relevant check to ensure that value passed is >= 0
KPull
reviewed
Oct 29, 2017
| public GlobalRequestAttributes timeout(long timeout) { | ||
| if (globalRequestTimeout < 0) { |
There was a problem hiding this comment.
You're not checking the argument here. You need to use timeout instead of globalRequestTimeout.
|
Thanks @FrelliBB for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #69