-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce the number of Bastion dependencies #58
base: develop
Are you sure you want to change the base?
Conversation
I talked with @FrelliBB about this who suggested we split up the optional modules into their own Maven modules. This is actually the suggested way of doing things, with the advice written on the same page which explains 'Optional Dependencies': https://maven.apache.org/guides/introduction/introduction-to-optional-and-excludes-dependencies.html We're going to try out how the whole structure will look like once we split everything up into dependencies. |
Fixing tests.
method does not take an entity. Updated the RequestExecutor to remove dependency on Unirest and use the plain HTTP client.
Moved assertJ dependency to test scope.
I've cleaned up the code so that we can mark the following two dependencies as optional:
If the user wants to use these features with Bastion, they need to add them to their own POM file first (they're not pulled automatically with Bastion).
This fixes: #57.