Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce the number of Bastion dependencies #58

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

KPull
Copy link
Member

@KPull KPull commented Dec 15, 2016

I've cleaned up the code so that we can mark the following two dependencies as optional:

  • JUnit 4
  • JMustache

If the user wants to use these features with Bastion, they need to add them to their own POM file first (they're not pulled automatically with Bastion).

This fixes: #57.

@KPull KPull self-assigned this Dec 15, 2016
@KPull KPull requested a review from FrelliBB December 15, 2016 17:17
@KPull KPull added this to the 0.5-BETA milestone Dec 15, 2016
@KPull
Copy link
Member Author

KPull commented Dec 16, 2016

I talked with @FrelliBB about this who suggested we split up the optional modules into their own Maven modules. This is actually the suggested way of doing things, with the advice written on the same page which explains 'Optional Dependencies': https://maven.apache.org/guides/introduction/introduction-to-optional-and-excludes-dependencies.html

We're going to try out how the whole structure will look like once we split everything up into dependencies.

@KPull KPull modified the milestones: 0.5-BETA, 0.6-BETA Jan 3, 2017
@KPull KPull modified the milestones: 0.6-BETA, 1.0 Mar 31, 2017
@FrelliBB FrelliBB removed their request for review January 30, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant