Skip to content

Commit

Permalink
Releasing version 0.4-BETA.
Browse files Browse the repository at this point in the history
  • Loading branch information
KPull committed Dec 8, 2016
1 parent 55bda5f commit 6b664aa
Show file tree
Hide file tree
Showing 169 changed files with 739 additions and 398 deletions.
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -109,15 +109,15 @@ dependency to your POM file:
<dependency>
<groupId>rocks.bastion</groupId>
<artifactId>bastion</artifactId>
<version>0.4-SNAPSHOT</version>
<version>0.4-BETA</version>
<scope>test</scope>
</dependency>
```

Alternatively, use Groovy Grapes to use Bastion in your Groovy tests/scripts:
```groovy
@Grapes(
@Grab(group='rocks.bastion', module='bastion', version='0.4-SNAPSHOT')
@Grab(group='rocks.bastion', module='bastion', version='0.4-BETA')
)
```

Expand Down
2 changes: 1 addition & 1 deletion docs/javadocs/allclasses-frame.html
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<head>
<!-- Generated by javadoc -->
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
<title>All Classes (Bastion 0.4-SNAPSHOT API)</title>
<title>All Classes (Bastion 0.4-BETA API)</title>
<link rel="stylesheet" type="text/css" href="stylesheet.css" title="Style">
<script type="text/javascript" src="script.js"></script>
</head>
Expand Down
2 changes: 1 addition & 1 deletion docs/javadocs/allclasses-noframe.html
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<head>
<!-- Generated by javadoc -->
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
<title>All Classes (Bastion 0.4-SNAPSHOT API)</title>
<title>All Classes (Bastion 0.4-BETA API)</title>
<link rel="stylesheet" type="text/css" href="stylesheet.css" title="Style">
<script type="text/javascript" src="script.js"></script>
</head>
Expand Down
4 changes: 2 additions & 2 deletions docs/javadocs/constant-values.html
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,15 @@
<head>
<!-- Generated by javadoc -->
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
<title>Constant Field Values (Bastion 0.4-SNAPSHOT API)</title>
<title>Constant Field Values (Bastion 0.4-BETA API)</title>
<link rel="stylesheet" type="text/css" href="stylesheet.css" title="Style">
<script type="text/javascript" src="script.js"></script>
</head>
<body>
<script type="text/javascript"><!--
try {
if (location.href.indexOf('is-external=true') == -1) {
parent.document.title="Constant Field Values (Bastion 0.4-SNAPSHOT API)";
parent.document.title="Constant Field Values (Bastion 0.4-BETA API)";
}
}
catch(err) {
Expand Down
4 changes: 2 additions & 2 deletions docs/javadocs/deprecated-list.html
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,15 @@
<head>
<!-- Generated by javadoc -->
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
<title>Deprecated List (Bastion 0.4-SNAPSHOT API)</title>
<title>Deprecated List (Bastion 0.4-BETA API)</title>
<link rel="stylesheet" type="text/css" href="stylesheet.css" title="Style">
<script type="text/javascript" src="script.js"></script>
</head>
<body>
<script type="text/javascript"><!--
try {
if (location.href.indexOf('is-external=true') == -1) {
parent.document.title="Deprecated List (Bastion 0.4-SNAPSHOT API)";
parent.document.title="Deprecated List (Bastion 0.4-BETA API)";
}
}
catch(err) {
Expand Down
4 changes: 2 additions & 2 deletions docs/javadocs/help-doc.html
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,15 @@
<head>
<!-- Generated by javadoc -->
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
<title>API Help (Bastion 0.4-SNAPSHOT API)</title>
<title>API Help (Bastion 0.4-BETA API)</title>
<link rel="stylesheet" type="text/css" href="stylesheet.css" title="Style">
<script type="text/javascript" src="script.js"></script>
</head>
<body>
<script type="text/javascript"><!--
try {
if (location.href.indexOf('is-external=true') == -1) {
parent.document.title="API Help (Bastion 0.4-SNAPSHOT API)";
parent.document.title="API Help (Bastion 0.4-BETA API)";
}
}
catch(err) {
Expand Down
44 changes: 42 additions & 2 deletions docs/javadocs/index-all.html
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,15 @@
<head>
<!-- Generated by javadoc -->
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
<title>Index (Bastion 0.4-SNAPSHOT API)</title>
<title>Index (Bastion 0.4-BETA API)</title>
<link rel="stylesheet" type="text/css" href="stylesheet.css" title="Style">
<script type="text/javascript" src="script.js"></script>
</head>
<body>
<script type="text/javascript"><!--
try {
if (location.href.indexOf('is-external=true') == -1) {
parent.document.title="Index (Bastion 0.4-SNAPSHOT API)";
parent.document.title="Index (Bastion 0.4-BETA API)";
}
}
catch(err) {
Expand Down Expand Up @@ -1088,6 +1088,11 @@ <h2 class="title">R</h2>
<div class="block">
Starts building a single Bastion test which will execute the specified HTTP request.</div>
</dd>
<dt><span class="memberNameLink"><a href="rocks/bastion/Bastion.html#request-rocks.bastion.core.HttpRequest-">request(HttpRequest)</a></span> - Static method in class rocks.bastion.<a href="rocks/bastion/Bastion.html" title="class in rocks.bastion">Bastion</a></dt>
<dd>
<div class="block">
Starts building a single Bastion test which will execute the specified HTTP request.</div>
</dd>
<dt><a href="rocks/bastion/core/RequestExecutor.html" title="class in rocks.bastion.core"><span class="typeNameLink">RequestExecutor</span></a> - Class in <a href="rocks/bastion/core/package-summary.html">rocks.bastion.core</a></dt>
<dd>
<div class="block">Responsible for executing a Bastion remote request built using the <a href="rocks/bastion/core/BastionBuilderImpl.html" title="class in rocks.bastion.core"><code>BastionBuilderImpl</code></a> builder and prepare a response object.</div>
Expand Down Expand Up @@ -1230,6 +1235,22 @@ <h2 class="title">S</h2>
<dd>
<div class="block">Sets whether assertions should be suppressed for this Bastion request.</div>
</dd>
<dt><span class="memberNameLink"><a href="rocks/bastion/core/CommonRequestAttributes.html#setTimeout-long-">setTimeout(long)</a></span> - Method in class rocks.bastion.core.<a href="rocks/bastion/core/CommonRequestAttributes.html" title="class in rocks.bastion.core">CommonRequestAttributes</a></dt>
<dd>
<div class="block">Set the timeout for all phases of a request.</div>
</dd>
<dt><span class="memberNameLink"><a href="rocks/bastion/core/FormUrlEncodedRequest.html#setTimeout-long-">setTimeout(long)</a></span> - Method in class rocks.bastion.core.<a href="rocks/bastion/core/FormUrlEncodedRequest.html" title="class in rocks.bastion.core">FormUrlEncodedRequest</a></dt>
<dd>
<div class="block">See <a href="rocks/bastion/core/HttpRequest.html#timeout--"><code>HttpRequest.timeout()</code></a> for details.</div>
</dd>
<dt><span class="memberNameLink"><a href="rocks/bastion/core/GeneralRequest.html#setTimeout-long-">setTimeout(long)</a></span> - Method in class rocks.bastion.core.<a href="rocks/bastion/core/GeneralRequest.html" title="class in rocks.bastion.core">GeneralRequest</a></dt>
<dd>
<div class="block">See <a href="rocks/bastion/core/HttpRequest.html#timeout--"><code>HttpRequest.timeout()</code></a> for details.</div>
</dd>
<dt><span class="memberNameLink"><a href="rocks/bastion/core/json/JsonRequest.html#setTimeout-long-">setTimeout(long)</a></span> - Method in class rocks.bastion.core.json.<a href="rocks/bastion/core/json/JsonRequest.html" title="class in rocks.bastion.core.json">JsonRequest</a></dt>
<dd>
<div class="block">See <a href="rocks/bastion/core/HttpRequest.html#timeout--"><code>HttpRequest.timeout()</code></a> for details.</div>
</dd>
<dt><span class="memberNameLink"><a href="rocks/bastion/core/CommonRequestAttributes.html#setUrl-java.lang.String-">setUrl(String)</a></span> - Method in class rocks.bastion.core.<a href="rocks/bastion/core/CommonRequestAttributes.html" title="class in rocks.bastion.core">CommonRequestAttributes</a></dt>
<dd>
<div class="block">Sets the URL to use for a request.</div>
Expand Down Expand Up @@ -1285,8 +1306,27 @@ <h2 class="title">T</h2>
<dd>
<div class="block">Attach a callback function to this Bastion test.</div>
</dd>
<dt><span class="memberNameLink"><a href="rocks/bastion/core/CommonRequestAttributes.html#timeout--">timeout()</a></span> - Method in class rocks.bastion.core.<a href="rocks/bastion/core/CommonRequestAttributes.html" title="class in rocks.bastion.core">CommonRequestAttributes</a></dt>
<dd>
<div class="block">See <a href="rocks/bastion/core/HttpRequest.html#timeout--"><code>HttpRequest.timeout()</code></a>.</div>
</dd>
<dt><span class="memberNameLink"><a href="rocks/bastion/core/configuration/GlobalRequestAttributes.html#timeout-long-">timeout(long)</a></span> - Method in class rocks.bastion.core.configuration.<a href="rocks/bastion/core/configuration/GlobalRequestAttributes.html" title="class in rocks.bastion.core.configuration">GlobalRequestAttributes</a></dt>
<dd>&nbsp;</dd>
<dt><span class="memberNameLink"><a href="rocks/bastion/core/FormUrlEncodedRequest.html#timeout--">timeout()</a></span> - Method in class rocks.bastion.core.<a href="rocks/bastion/core/FormUrlEncodedRequest.html" title="class in rocks.bastion.core">FormUrlEncodedRequest</a></dt>
<dd>&nbsp;</dd>
<dt><span class="memberNameLink"><a href="rocks/bastion/core/GeneralRequest.html#timeout--">timeout()</a></span> - Method in class rocks.bastion.core.<a href="rocks/bastion/core/GeneralRequest.html" title="class in rocks.bastion.core">GeneralRequest</a></dt>
<dd>&nbsp;</dd>
<dt><span class="memberNameLink"><a href="rocks/bastion/core/HttpRequest.html#timeout--">timeout()</a></span> - Method in interface rocks.bastion.core.<a href="rocks/bastion/core/HttpRequest.html" title="interface in rocks.bastion.core">HttpRequest</a></dt>
<dd>
<div class="block">A timeout (in milliseconds) that will cause tests to cutoff if:

the connection takes too long to be established
the response takes too long to arrive.

Note that these are 2 separate timeouts; the test might take (in the worst case) <b>twice</b> the value of the timeout, if the phases mentioned above take long enough.</div>
</dd>
<dt><span class="memberNameLink"><a href="rocks/bastion/core/json/JsonRequest.html#timeout--">timeout()</a></span> - Method in class rocks.bastion.core.json.<a href="rocks/bastion/core/json/JsonRequest.html" title="class in rocks.bastion.core.json">JsonRequest</a></dt>
<dd>&nbsp;</dd>
<dt><span class="memberNameLink"><a href="rocks/bastion/core/HttpMethod.html#toString--">toString()</a></span> - Method in class rocks.bastion.core.<a href="rocks/bastion/core/HttpMethod.html" title="class in rocks.bastion.core">HttpMethod</a></dt>
<dd>&nbsp;</dd>
</dl>
Expand Down
13 changes: 7 additions & 6 deletions docs/javadocs/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,14 @@
<head>
<!-- Generated by javadoc -->
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
<title>Bastion 0.4-SNAPSHOT API</title>
<title>Bastion 0.4-BETA API</title>
<script type="text/javascript">
targetPage = "" + window.location.search;
if (targetPage != "" && targetPage != "undefined")
targetPage = targetPage.substring(1);
if (targetPage.indexOf(":") != -1 || (targetPage != "" && !validURL(targetPage)))
targetPage = "undefined";
tmpTargetPage = "" + window.location.search;
if (tmpTargetPage != "" && tmpTargetPage != "undefined")
tmpTargetPage = tmpTargetPage.substring(1);
if (tmpTargetPage.indexOf(":") != -1 || (tmpTargetPage != "" && !validURL(tmpTargetPage)))
tmpTargetPage = "undefined";
targetPage = tmpTargetPage;
function validURL(url) {
try {
url = decodeURIComponent(url);
Expand Down
2 changes: 1 addition & 1 deletion docs/javadocs/overview-frame.html
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<head>
<!-- Generated by javadoc -->
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
<title>Overview List (Bastion 0.4-SNAPSHOT API)</title>
<title>Overview List (Bastion 0.4-BETA API)</title>
<link rel="stylesheet" type="text/css" href="stylesheet.css" title="Style">
<script type="text/javascript" src="script.js"></script>
</head>
Expand Down
6 changes: 3 additions & 3 deletions docs/javadocs/overview-summary.html
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,15 @@
<head>
<!-- Generated by javadoc -->
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
<title>Overview (Bastion 0.4-SNAPSHOT API)</title>
<title>Overview (Bastion 0.4-BETA API)</title>
<link rel="stylesheet" type="text/css" href="stylesheet.css" title="Style">
<script type="text/javascript" src="script.js"></script>
</head>
<body>
<script type="text/javascript"><!--
try {
if (location.href.indexOf('is-external=true') == -1) {
parent.document.title="Overview (Bastion 0.4-SNAPSHOT API)";
parent.document.title="Overview (Bastion 0.4-BETA API)";
}
}
catch(err) {
Expand Down Expand Up @@ -70,7 +70,7 @@
</a></div>
<!-- ========= END OF TOP NAVBAR ========= -->
<div class="header">
<h1 class="title">Bastion 0.4-SNAPSHOT API</h1>
<h1 class="title">Bastion 0.4-BETA API</h1>
</div>
<div class="contentContainer">
<table class="overviewSummary" border="0" cellpadding="3" cellspacing="0" summary="Packages table, listing packages, and an explanation">
Expand Down
4 changes: 2 additions & 2 deletions docs/javadocs/overview-tree.html
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,15 @@
<head>
<!-- Generated by javadoc -->
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
<title>Class Hierarchy (Bastion 0.4-SNAPSHOT API)</title>
<title>Class Hierarchy (Bastion 0.4-BETA API)</title>
<link rel="stylesheet" type="text/css" href="stylesheet.css" title="Style">
<script type="text/javascript" src="script.js"></script>
</head>
<body>
<script type="text/javascript"><!--
try {
if (location.href.indexOf('is-external=true') == -1) {
parent.document.title="Class Hierarchy (Bastion 0.4-SNAPSHOT API)";
parent.document.title="Class Hierarchy (Bastion 0.4-BETA API)";
}
}
catch(err) {
Expand Down
36 changes: 33 additions & 3 deletions docs/javadocs/rocks/bastion/Bastion.html
Original file line number Diff line number Diff line change
Expand Up @@ -4,21 +4,21 @@
<head>
<!-- Generated by javadoc -->
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
<title>Bastion (Bastion 0.4-SNAPSHOT API)</title>
<title>Bastion (Bastion 0.4-BETA API)</title>
<link rel="stylesheet" type="text/css" href="../../stylesheet.css" title="Style">
<script type="text/javascript" src="../../script.js"></script>
</head>
<body>
<script type="text/javascript"><!--
try {
if (location.href.indexOf('is-external=true') == -1) {
parent.document.title="Bastion (Bastion 0.4-SNAPSHOT API)";
parent.document.title="Bastion (Bastion 0.4-BETA API)";
}
}
catch(err) {
}
//-->
var methods = {"i0":9,"i1":9,"i2":9};
var methods = {"i0":9,"i1":9,"i2":9,"i3":9};
var tabs = {65535:["t0","All Methods"],1:["t1","Static Methods"],8:["t4","Concrete Methods"]};
var altColor = "altColor";
var rowColor = "rowColor";
Expand Down Expand Up @@ -283,6 +283,13 @@ <h3>Method Summary</h3>
</tr>
<tr id="i2" class="altColor">
<td class="colFirst"><code>static <a href="../../rocks/bastion/core/builder/BastionBuilder.html" title="interface in rocks.bastion.core.builder">BastionBuilder</a>&lt;<a href="http://docs.oracle.com/javase/7/docs/api/java/lang/Object.html?is-external=true" title="class or interface in java.lang">Object</a>&gt;</code></td>
<td class="colLast"><code><span class="memberNameLink"><a href="../../rocks/bastion/Bastion.html#request-rocks.bastion.core.HttpRequest-">request</a></span>(<a href="../../rocks/bastion/core/HttpRequest.html" title="interface in rocks.bastion.core">HttpRequest</a>&nbsp;request)</code>
<div class="block">
Starts building a single Bastion test which will execute the specified HTTP request.</div>
</td>
</tr>
<tr id="i3" class="rowColor">
<td class="colFirst"><code>static <a href="../../rocks/bastion/core/builder/BastionBuilder.html" title="interface in rocks.bastion.core.builder">BastionBuilder</a>&lt;<a href="http://docs.oracle.com/javase/7/docs/api/java/lang/Object.html?is-external=true" title="class or interface in java.lang">Object</a>&gt;</code></td>
<td class="colLast"><code><span class="memberNameLink"><a href="../../rocks/bastion/Bastion.html#request-java.lang.String-rocks.bastion.core.HttpRequest-">request</a></span>(<a href="http://docs.oracle.com/javase/7/docs/api/java/lang/String.html?is-external=true" title="class or interface in java.lang">String</a>&nbsp;message,
<a href="../../rocks/bastion/core/HttpRequest.html" title="interface in rocks.bastion.core">HttpRequest</a>&nbsp;request)</code>
<div class="block">
Expand Down Expand Up @@ -337,6 +344,29 @@ <h4>request</h4>
</dl>
</li>
</ul>
<a name="request-rocks.bastion.core.HttpRequest-">
<!-- -->
</a>
<ul class="blockList">
<li class="blockList">
<h4>request</h4>
<pre>public static&nbsp;<a href="../../rocks/bastion/core/builder/BastionBuilder.html" title="interface in rocks.bastion.core.builder">BastionBuilder</a>&lt;<a href="http://docs.oracle.com/javase/7/docs/api/java/lang/Object.html?is-external=true" title="class or interface in java.lang">Object</a>&gt;&nbsp;request(<a href="../../rocks/bastion/core/HttpRequest.html" title="interface in rocks.bastion.core">HttpRequest</a>&nbsp;request)</pre>
<div class="block"><p>
Starts building a single Bastion test which will execute the specified HTTP request. The method will return a
fluent-builder object which will let you specify the test further.
</p>
<p>
The request you specify in this method can be an instance of one of the in-built <a href="../../rocks/bastion/core/HttpRequest.html" title="interface in rocks.bastion.core"><code>request types</code></a>
provided with Bastion itself. You can also supply your own implementation of a request by subclassing <a href="../../rocks/bastion/core/HttpRequest.html" title="interface in rocks.bastion.core"><code>HttpRequest</code></a>.
</p></div>
<dl>
<dt><span class="paramLabel">Parameters:</span></dt>
<dd><code>request</code> - The HTTP request that Bastion will execute for this test.</dd>
<dt><span class="returnLabel">Returns:</span></dt>
<dd>A fluent-builder object which will let you bind a model type, add assertions, add callbacks and execute the test.</dd>
</dl>
</li>
</ul>
<a name="loadConfiguration-java.lang.String-">
<!-- -->
</a>
Expand Down
4 changes: 2 additions & 2 deletions docs/javadocs/rocks/bastion/class-use/Bastion.html
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,15 @@
<head>
<!-- Generated by javadoc -->
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
<title>Uses of Class rocks.bastion.Bastion (Bastion 0.4-SNAPSHOT API)</title>
<title>Uses of Class rocks.bastion.Bastion (Bastion 0.4-BETA API)</title>
<link rel="stylesheet" type="text/css" href="../../../stylesheet.css" title="Style">
<script type="text/javascript" src="../../../script.js"></script>
</head>
<body>
<script type="text/javascript"><!--
try {
if (location.href.indexOf('is-external=true') == -1) {
parent.document.title="Uses of Class rocks.bastion.Bastion (Bastion 0.4-SNAPSHOT API)";
parent.document.title="Uses of Class rocks.bastion.Bastion (Bastion 0.4-BETA API)";
}
}
catch(err) {
Expand Down
4 changes: 2 additions & 2 deletions docs/javadocs/rocks/bastion/core/ApiDataParameter.html
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,15 @@
<head>
<!-- Generated by javadoc -->
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
<title>ApiDataParameter (Bastion 0.4-SNAPSHOT API)</title>
<title>ApiDataParameter (Bastion 0.4-BETA API)</title>
<link rel="stylesheet" type="text/css" href="../../../stylesheet.css" title="Style">
<script type="text/javascript" src="../../../script.js"></script>
</head>
<body>
<script type="text/javascript"><!--
try {
if (location.href.indexOf('is-external=true') == -1) {
parent.document.title="ApiDataParameter (Bastion 0.4-SNAPSHOT API)";
parent.document.title="ApiDataParameter (Bastion 0.4-BETA API)";
}
}
catch(err) {
Expand Down
4 changes: 2 additions & 2 deletions docs/javadocs/rocks/bastion/core/ApiHeader.html
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,15 @@
<head>
<!-- Generated by javadoc -->
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
<title>ApiHeader (Bastion 0.4-SNAPSHOT API)</title>
<title>ApiHeader (Bastion 0.4-BETA API)</title>
<link rel="stylesheet" type="text/css" href="../../../stylesheet.css" title="Style">
<script type="text/javascript" src="../../../script.js"></script>
</head>
<body>
<script type="text/javascript"><!--
try {
if (location.href.indexOf('is-external=true') == -1) {
parent.document.title="ApiHeader (Bastion 0.4-SNAPSHOT API)";
parent.document.title="ApiHeader (Bastion 0.4-BETA API)";
}
}
catch(err) {
Expand Down
4 changes: 2 additions & 2 deletions docs/javadocs/rocks/bastion/core/ApiProperty.html
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,15 @@
<head>
<!-- Generated by javadoc -->
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
<title>ApiProperty (Bastion 0.4-SNAPSHOT API)</title>
<title>ApiProperty (Bastion 0.4-BETA API)</title>
<link rel="stylesheet" type="text/css" href="../../../stylesheet.css" title="Style">
<script type="text/javascript" src="../../../script.js"></script>
</head>
<body>
<script type="text/javascript"><!--
try {
if (location.href.indexOf('is-external=true') == -1) {
parent.document.title="ApiProperty (Bastion 0.4-SNAPSHOT API)";
parent.document.title="ApiProperty (Bastion 0.4-BETA API)";
}
}
catch(err) {
Expand Down
Loading

0 comments on commit 6b664aa

Please sign in to comment.